Added support for 3 digit hex colors#455
Closed
arthuralee wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for contribution! We merged the patch internally, should be out with the next sync. |
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 13, 2015
Summary: This addition adds a check for whether a hex color is 3 or 6 digits. If it is 3 digits, it will expand the short form into 6 digits, just like in CSS. The additional benefit of having the length check is that hex colors of invalid lengths (like 4 digits) will be considered invalid. In CSS, invalid length hex colors returns white, but here I have logged an error through `RCTLogError`. Closes react#455 Github Author: Arthur Lee <arthur@arthurlee.me> Test Plan: Tried a couple of colors in the sample app, like `#FACEB0`, `#F00`, etc.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 14, 2015
Summary: This addition adds a check for whether a hex color is 3 or 6 digits. If it is 3 digits, it will expand the short form into 6 digits, just like in CSS. The additional benefit of having the length check is that hex colors of invalid lengths (like 4 digits) will be considered invalid. In CSS, invalid length hex colors returns white, but here I have logged an error through `RCTLogError`. Closes react#455 Github Author: Arthur Lee <arthur@arthurlee.me> Test Plan: Tried a couple of colors in the sample app, like `#FACEB0`, `#F00`, etc.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 15, 2015
Summary: This addition adds a check for whether a hex color is 3 or 6 digits. If it is 3 digits, it will expand the short form into 6 digits, just like in CSS. The additional benefit of having the length check is that hex colors of invalid lengths (like 4 digits) will be considered invalid. In CSS, invalid length hex colors returns white, but here I have logged an error through `RCTLogError`. Closes react#455 Github Author: Arthur Lee <arthur@arthurlee.me> Test Plan: Tried a couple of colors in the sample app, like `#FACEB0`, `#F00`, etc.
jfrolich
pushed a commit
to jfrolich/react-native
that referenced
this pull request
Apr 22, 2020
tido64
pushed a commit
to tido64/react-native
that referenced
this pull request
Jun 19, 2020
…ed (react#455) * Attempting to add isVoiceOverEnabled to macOS * removing console.log * Removed Merge conflicts * Resolved merge conflict * Removed comments/notes * Removed comments/notes * Added Features and encorporated into test app * Removed logging * Fixed mistakes in PR * Changing name to DisplayOptions * Removing extra newlines * Adding linting fixes * Added Notifaction unsubscribe to dealloc * Lowercased selector to fit obj-c convention * uncommented unsubscription * Added TODOs around diff * Put ScreenReaderStatus back in it's own component * Lint fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addition adds a check for whether a hex color is 3 or 6 digits. If it is 3 digits, it will expand the short form into 6 digits, just like in CSS. The additional benefit of having the length check is that hex colors of invalid lengths (like 4 digits) will be considered invalid. In CSS, invalid length hex colors returns white, but here I have logged an error through
RCTLogError.