[iOS] Fabric: Fixes insets not adjust when keyboard disappear#47924
Closed
zhongwuzw wants to merge 1 commit into
Closed
[iOS] Fabric: Fixes insets not adjust when keyboard disappear#47924zhongwuzw wants to merge 1 commit into
zhongwuzw wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
zhongwuzw
commented
Nov 27, 2024
|
|
||
| if (CGRectIsNull(viewIntersection)) { | ||
| return; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Paper infra doesn't have this quick return logic.
cipolleschi
approved these changes
Dec 2, 2024
cipolleschi
left a comment
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
thanks for looking into this.
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in efcfe5d. |
Collaborator
|
This pull request was successfully merged by @zhongwuzw in efcfe5d When will my fix make it into a release? | How to file a pick request? |
Collaborator
|
This pull request was successfully merged by @zhongwuzw in d105c2c When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
that referenced
this pull request
Dec 9, 2024
Summary: Fixes #47731 . ## Changelog: [IOS] [FIXED] - Fabric: Fixes insets not adjust when keyboard disappear Pull Request resolved: #47924 Test Plan: Demo in #47731 Reviewed By: blakef Differential Revision: D66651865 Pulled By: cipolleschi fbshipit-source-id: a75afbd1a7651f0c77022d913f910821c482fcf7
Collaborator
|
This pull request was successfully merged by @zhongwuzw in 19bff65 When will my fix make it into a release? | How to file a pick request? |
This was referenced Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #47731 .
Changelog:
[IOS] [FIXED] - Fabric: Fixes insets not adjust when keyboard disappear
Test Plan:
Demo in #47731