Fixing Fabric Interop layer bug defaulting to UnstableLegacyViewManagerAutomaticComponentDescriptor irrespective of feature flag#50186
Closed
arushikesarwani94 wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71582553 |
arushikesarwani94
force-pushed
the
export-D71582553
branch
from
5af922c to
dc79721
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71582553 |
…erAutomaticComponentDescriptor irrespective of feature flag (react#50186) Summary: When `useFabricInterop` is disabled, deleting component descriptors in Component Registry is failing since react#47321 removed the Fabric Interop check from the ComponentDescriptorRegistry.cpp which was added earlier in react#42294 Adding back the logic of Fallback component descriptor and error for the same. Changelog: [General][Fixed] Fixing Fabric Interop layer bug defaulting to UnstableLegacyViewManagerAutomaticComponentDescriptor irrespective of feature flags Differential Revision: D71582553
arushikesarwani94
force-pushed
the
export-D71582553
branch
from
dc79721 to
14c1fed
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71582553 |
Contributor
|
This pull request has been merged in 529c24a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When
useFabricInteropis disabled, deleting component descriptors in Component Registry is failing since #47321 removed the Fabric Interop check from the ComponentDescriptorRegistry.cpp which was added earlier in #42294Adding back the logic of Fallback component descriptor and error for the same.
Changelog:
[General][Fixed] Fixing Fabric Interop layer bug defaulting to UnstableLegacyViewManagerAutomaticComponentDescriptor irrespective of feature flags
Differential Revision: D71582553