fix: pressability issues new arch by hannojg · Pull Request #51835 · react/react-native

hannojg · 2025-06-05T10:57:20Z

Summary:

Addresses: #51621

Fixes press ability issues on new arch by adding a separate path for measuring, called:

measureAsyncOnUI

this method will call into the platform MountingManager implementations to measure using just the native view hierarchy.
This way the measurement should always be correct.

Note: the method for measuring is basically copied over from old arch code.

Changelog:

[GENERAL] [ADDED] Add HostInstance.measureAsyncOnUI(callback) for measuring host views from the native view hierarchy on the UI thread.

[GENERAL] [FIXED] Pressability issues on new arch

Test Plan:

Test press ability section in rn-tester
Run this code example in the playground on main VS on these diffs to verify that press ability during animation works now: https://github.com/hannojg/rn-animated-pressability/blob/main/ReproducerApp/App.tsx

Hardanish-Singh

LGTM!

klxiaoniu · 2025-08-05T02:05:22Z

Any updates on this?

oleksandr-dziuban · 2025-08-06T12:38:08Z

Hello guys, can this fix be cherry-picked into v0.80.x, for example ?

Dallas62 · 2025-08-21T17:17:43Z

Will also check if this resolve #53366 in next hours.

EDIT:
Maybe I'm testing it not the right way, but I always face this:

SzyVsSi · 2025-08-22T08:37:46Z

Any alternative solutions while we wait for this PR to be merged?

Bowlerr · 2025-08-28T16:21:13Z

👀

joacub · 2025-09-05T18:42:57Z

when is this going to be merged ?

just-myself · 2025-10-13T09:11:42Z

Any updates on this?

hannojg · 2025-10-16T10:59:07Z

Let me update this PR today or tmrw so there are no merge conflicts and it works with the latest main, then we can maybe move it forward!

react-native-bot · 2025-10-21T08:42:02Z

	Warnings
⚠️	❗ JavaScript API change detected - This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API. Please include a clear changelog message. This change will be subject to extra review. This change was flagged as: `BREAKING`

Generated by 🚫 dangerJS against 7f2df56

hannojg · 2025-10-21T08:44:20Z

Hey, I rewrote this PR to be mergable against main.
The main change here was that we need to call through the NativeDOM module. I added the new measureAsyncOnUI method there, can we please double check whether this is the correct place for it?
Alternatively we could call to the fabric ui manager, but it seems to me we want to avoid that in NativeDOM ?

Kindly requesting another round of review @Hardanish-Singh
Will also ping maintainers on discord!

For folks needing this fix for older RN versions, I kept a copy of the old branch targeting RN 0.79 here:

main...hannojg:react-native:fix/pressability-issues-by-measuring-native-view-hierarchy-rn-079

cipolleschi

This change is kind of big and touches multiple parts of React Native.
I strongly suggest to wrap it within a feature flag so we can easily switch back to the old behavior in case it misbehave in prod in our apps.

ideally, it would be better if you can split it in smaller pieces, but perhaps it is easier to review as a whole for an approval and then we can split it.

I don't have the full picture on this, so I'll forward to somebody in the team that can provide a good review.

hannojg · 2025-10-21T09:34:11Z

Thanks for the first quick check! Let me add a feature flag first. The feature flag could gate this call in

packages/react-native/Libraries/Pressability/Pressability.js:

    if (typeof this._responderID === 'number') {
      UIManager.measure(this._responderID, this._measureCallback);
    } else {
-      this._responderID.measure(this._measureCallback);
+      this._responderID.measureAsyncOnUI(this._measureCallback);
    }
  }

Putting the native code behind a feature flag would be a bit difficult since we touch turbo module specs.

Adding a new virtual method to the scheduler kind of trickles down into all those places touched here, so it would be a bit hard to split the PR up otherwise.

## **Description** Ported patch from react/react-native#51835 to version 0.76.9 I also had to enable build from source for Android in order to make patch work, that will result in increased build time. ## **Changelog**  CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.  --- > [!NOTE] > Introduces a React Native patch adding `measureAsyncOnUI` across Fabric/UIManager and switches app components to plain `TouchableOpacity`, while enabling Android builds to compile RN from source. > > - **React Native (patched)**: > - Add `measureAsyncOnUI` API across Fabric/UIManager (JS, iOS, Android, JNI) and expose via `UIManagerBinding`. > - Update `Pressability` and `ReactFabricHostComponent` to use `measureAsyncOnUI` for view measurement. > - **Android Build**: > - Enable building `react-native` from source with Gradle dependency substitutions. > - **App Components**: > - Simplify touch handling in `ButtonBase`, `ListItemMultiSelect`, and `ListItemSelect` by removing `react-native-gesture-handler` tap wrappers and using `RNTouchableOpacity` directly. > - **Tooling**: > - Add Yarn patch/resolution for `react-native@0.76.9` and update `yarn.lock`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit da7a9a0. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>

Dallas62 · 2025-12-10T22:21:38Z

Hi @cipolleschi,

It would be great if someone from Meta could take a look to all pressability issues in new arch or try to implement the requested feature flag.

It's a bug present and reported multiples time from months now...

lodev09 · 2026-01-01T02:08:19Z

The Pressable onPress issue is breaking TrueSheet nesting capabilities 😢. Hopefully this gets merged soon! 🙏

Add react-native patch based on upstream PR react/react-native#51835 to fix Android-specific onPress failures for Pressable components inside Tooltip on certain Samsung devices. The root cause is that Pressability.measure() reads stale layout info from the shadow tree while Reanimated has already updated the native view. This patch introduces measureAsyncOnUI which measures using the native view hierarchy on the UI thread. Also removes the createPressHandler workaround since this patch properly fixes the root cause. Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>

Add react-native patch based on upstream PR react/react-native#51835 to fix Android-specific issue where onPress events do not trigger for Pressable components when used inside a Tooltip on certain Samsung devices. Also removes the createPressHandler workaround since this patch properly fixes the root cause. Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>

Re-apply the changes from PR #86160 which was reverted. Adds a react-native patch based on upstream react/react-native#51835 to fix onPress events not triggering for Pressable components inside Tooltips on certain Samsung devices. Also removes the createPressHandler workaround since this patch properly fixes the root cause. Co-authored-by: linhvovan29546 <linhvovan29546@gmail.com> Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>

Re-apply the changes from PR #86160 which was reverted. Adds a react-native patch based on upstream react/react-native#51835 to fix onPress events not triggering for Pressable components inside Tooltips on certain Samsung devices. Also removes the createPressHandler workaround since this patch properly fixes the root cause.

…nativeDOM

github-actions · 2026-06-18T07:29:55Z

Warning

JavaScript API change detected

This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API.

Please include a clear changelog message.
This change will be subject to additional review.

This change was flagged as: POTENTIALLY_BREAKING

hannojg · 2026-06-18T07:59:01Z

@cipolleschi

I updated this PR to be mergeable against main
I hide this behind a new feature flag, shouldPressabilityUseNativeViewHierarchyForMeasurement which by default is off
I think its a bit difficult to split up, except maybe for feature flag introduction VS actual code changes, let me know if thats preferred!

Would appreciate it very much if we could revisit this PR, thanks in advance! 😊

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2025

hannojg marked this pull request as ready for review June 5, 2025 11:28

This was referenced Jun 5, 2025

onPress not working while animating views #51621

Open

[Due for payment 2026-04-14] [Due for payment 2026-04-07] [$375] Android: Investigate and fix onPress not working for Pressable in Tooltip Expensify/App#59953

Closed

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jun 5, 2025

Hardanish-Singh reviewed Jun 7, 2025

View reviewed changes

sethkfman mentioned this pull request Aug 27, 2025

Android OnPress Event Issue MetaMask/metamask-mobile#18838

Open

9 tasks

wgsquayson mentioned this pull request Sep 10, 2025

fix: android pressability issue on tooltips Expensify/App#69885

Closed

49 tasks

hannojg force-pushed the fix/pressability-issues-by-measuring-native-view-hierarchy branch from de24f92 to 272dcfd Compare October 21, 2025 08:37

cipolleschi requested changes Oct 21, 2025

View reviewed changes

Nodonisko mentioned this pull request Oct 21, 2025

fix: fix touchable issues in ScrollView MetaMask/metamask-mobile#21466

Merged

7 tasks

ysitbon mentioned this pull request Oct 23, 2025

chore: migrate to react-native new-arch LedgerHQ/ledger-live#11549

Merged

3 tasks

lodev09 mentioned this pull request Dec 31, 2025

Android New Architecture no press event lodev09/react-native-true-sheet#163

Closed

3 tasks

MelvinBot mentioned this pull request Mar 17, 2026

fix: android pressability issue with measureAsyncOnUI patch Expensify/App#85543

Closed

49 tasks

MelvinBot mentioned this pull request Mar 19, 2026

fix: android pressability issue with measureAsyncOnUI patch Expensify/App#85745

Closed

49 tasks

MelvinBot mentioned this pull request Mar 24, 2026

fix: android pressability issue with measureAsyncOnUI patch Expensify/App#86160

Merged

58 tasks

MelvinBot mentioned this pull request Mar 31, 2026

fix: android pressability issue with measureAsyncOnUI patch Expensify/App#86707

Closed

52 tasks

MelvinBot mentioned this pull request Mar 31, 2026

fix: android pressability issue with measureAsyncOnUI patch (v5) Expensify/App#86708

Merged

52 tasks

WoLewicki mentioned this pull request Apr 17, 2026

feat: implement ios part of measureOnUI discord/react-native-archived#163

Merged

oqildev mentioned this pull request May 21, 2026

[Due for payment 2026-06-04] [Sentry: APP-7B2] HybridApp iOS Fatal App Hang in Fabric ComponentDescriptorRegistry::findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN Expensify/App#91292

Closed

This was referenced Jun 17, 2026

Fix/pressability issues by measuring native view hierarchy #57254

Closed

Fix/pressability issues by measuring native view hierarchy discord/react-native#3

Open

hannojg added 7 commits June 18, 2026 09:24

fix(android): fix pressability issues, introduce measureAsyncOnUI to …

22ac6bc

…nativeDOM

add copyright header

070a557

implement iOS

96a10ab

formatting

f8f3c0c

yarn run build-types

5207ac3

use correct callback type

b152f14

fix fantom test

7aa9495

hannojg force-pushed the fix/pressability-issues-by-measuring-native-view-hierarchy branch from 7f2df56 to 7aa9495 Compare June 18, 2026 07:28

hannojg added 4 commits June 18, 2026 09:35

feat(pressability): gate native hierarchy measurement

43be869

chore(featureflags): regenerate pressability flag

172379e

fix(pressability): resolve measurement flow errors

0b83307

chore(cxx-api): update measurement snapshots

38d1c56

hannojg requested a review from cipolleschi June 18, 2026 08:01

hannojg added 2 commits June 18, 2026 10:34

fix(ios): avoid duplicate fabric surface include

db2e228

chore(ci): retrigger pipeline

57b38c6

Conversation

hannojg commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan:

Uh oh!

Hardanish-Singh left a comment

Choose a reason for hiding this comment

Uh oh!

klxiaoniu commented Aug 5, 2025

Uh oh!

oleksandr-dziuban commented Aug 6, 2025

Uh oh!

Dallas62 commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SzyVsSi commented Aug 22, 2025

Uh oh!

Bowlerr commented Aug 28, 2025

Uh oh!

joacub commented Sep 5, 2025

Uh oh!

just-myself commented Oct 13, 2025

Uh oh!

hannojg commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

react-native-bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hannojg commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cipolleschi left a comment

Choose a reason for hiding this comment

Uh oh!

hannojg commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dallas62 commented Dec 10, 2025

Uh oh!

lodev09 commented Jan 1, 2026

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

hannojg commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

hannojg commented Jun 5, 2025 •

edited

Loading

Dallas62 commented Aug 21, 2025 •

edited

Loading

hannojg commented Oct 16, 2025 •

edited

Loading

react-native-bot commented Oct 21, 2025 •

edited

Loading

hannojg commented Oct 21, 2025 •

edited

Loading

hannojg commented Oct 21, 2025 •

edited

Loading