Skip to content

Do not override (xc)framework's Info.plist files with RCTNewArchEnabled #54771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fgagneten-02 wants to merge 1 commit into from
Closed

Do not override (xc)framework's Info.plist files with RCTNewArchEnabled #54771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions packages/react-native/scripts/cocoapods/new_architecture.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def self.set_RCTNewArchEnabled_in_info_plist(installer, new_arch_enabled)
.uniq{ |p| p.path }
.map{ |p| p.path }

excluded_info_plist = ["/Pods", "Tests", "metainternal", ".bundle", "build/", "DerivedData/"]
excluded_info_plist = ["/Pods", "Tests", "metainternal", ".bundle", "build/", "DerivedData/", ".framework", ".xcframework"]
projectPaths.each do |projectPath|
projectFolderPath = File.dirname(projectPath)
infoPlistFiles = `find #{projectFolderPath} -name "Info.plist"`
Expand All @@ -179,8 +179,31 @@ def self.set_RCTNewArchEnabled_in_info_plist(installer, new_arch_enabled)
end
next if should_skip

# Skip binary plist files to avoid UTF-8 encoding errors
begin
# Check if file is readable as UTF-8 text
File.open(infoPlistFile, 'r:UTF-8') do |file|
# Try to read first few bytes to detect binary format
first_bytes = file.read(6)
# Binary plist files start with 'bplist'
if first_bytes && first_bytes.start_with?('bplist')
next
end
end
rescue Encoding::InvalidByteSequenceError, Encoding::UndefinedConversionError
# Skip files that can't be read as UTF-8
next
end

# Read the file as a plist
info_plist = Xcodeproj::Plist.read_from_path(infoPlistFile)
begin
info_plist = Xcodeproj::Plist.read_from_path(infoPlistFile)
rescue => e
# Skip files that can't be parsed as plist
Pod::UI.warn("Skipping Info.plist file that could not be parsed: #{infoPlistFile}")
next
end

# Check if it contains the RCTNewArchEnabled key
if info_plist["RCTNewArchEnabled"] and info_plist["RCTNewArchEnabled"] == new_arch_enabled
next
Expand Down