Skip to content

Fix binary FormData uploads on Android #54917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huntie wants to merge 1 commit into from
Closed

Fix binary FormData uploads on Android #54917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions ...tive/ReactAndroid/src/main/java/com/facebook/react/modules/network/ProgressRequestBody.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ internal class ProgressRequestBody(
) : RequestBody() {
private var contentLength = 0L

companion object {
private const val MAX_BODY_PREVIEW_SIZE = 1024 * 1024 // 1MB
}

override fun contentType(): MediaType? {
return requestBody.contentType()
}
Expand Down Expand Up @@ -84,18 +80,7 @@ internal class ProgressRequestBody(
}

fun getBodyPreview(): String {
return try {
val buffer = okio.Buffer()
requestBody.writeTo(buffer)
val size = buffer.size()
if (size <= MAX_BODY_PREVIEW_SIZE) {
buffer.readUtf8()
} else {
buffer.readUtf8(MAX_BODY_PREVIEW_SIZE.toLong()) +
"\n... [truncated, showing $MAX_BODY_PREVIEW_SIZE of $size bytes]"
}
} catch (e: Exception) {
""
}
// TODO: Safely implement request body previews
return "[Preview unavailable]"
}
}
Loading