-
Notifications
You must be signed in to change notification settings - Fork 25.2k
chore: Mark UTFSequence as deprecated to remove in the future #57122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -368,6 +368,10 @@ module.exports = { | |||||||||||||
| return require('./Libraries/Utilities/useWindowDimensions').default; | ||||||||||||||
| }, | ||||||||||||||
| get UTFSequence() { | ||||||||||||||
| warnOnce( | ||||||||||||||
| 'utfsequence-will-be-remove', | ||||||||||||||
| 'UTFSequence will be removed in a future release.', | ||||||||||||||
|
Comment on lines
+372
to
+373
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggested wording:
Suggested change
Can we also add an react-native/packages/react-native/Libraries/UTFSequence.js Lines 22 to 23 in 9d03750
This comment was marked as outdated.
Sorry, something went wrong.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, yup this is a temporary ongoing thing after the repo move. Please try again in a few hours 🙏🏻 |
||||||||||||||
| ); | ||||||||||||||
| return require('./Libraries/UTFSequence').default; | ||||||||||||||
| }, | ||||||||||||||
| get Vibration() { | ||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a line on what the user should use instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add, what do @cortinico think can be used instead ?