Skip to content

Construct the shared animation backend after the UIManager has a delegate (#57817) #57817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zeyap wants to merge 1 commit into from
+13 −10
Closed

Construct the shared animation backend after the UIManager has a delegate (#57817) #57817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,6 @@ Scheduler::Scheduler(
auto uiManager =
std::make_shared<UIManager>(runtimeExecutor_, contextContainer_);

if (ReactNativeFeatureFlags::useSharedAnimatedBackend()) {
auto animationBackend = std::make_shared<AnimationBackend>(
schedulerToolbox.animationChoreographer, uiManager);

schedulerToolbox.animationChoreographer->setAnimationBackend(
animationBackend);

uiManager->unstable_setAnimationBackend(animationBackend);
}

auto eventOwnerBox = std::make_shared<EventBeat::OwnerBox>();
eventOwnerBox->owner = eventDispatcher_;

Expand Down Expand Up @@ -131,6 +121,19 @@ Scheduler::Scheduler(
uiManager->setDelegate(this);
uiManager->setComponentDescriptorRegistry(componentDescriptorRegistry_);

// Must come after `setDelegate`: the backend's constructor registers a
// surface-start callback, and `UIManager` silently drops those while it has
// no delegate.
if (ReactNativeFeatureFlags::useSharedAnimatedBackend()) {
auto animationBackend = std::make_shared<AnimationBackend>(
schedulerToolbox.animationChoreographer, uiManager);

schedulerToolbox.animationChoreographer->setAnimationBackend(
animationBackend);

uiManager->unstable_setAnimationBackend(animationBackend);
}

auto bindingsExecutor =
schedulerToolbox.bridgelessBindingsExecutor.has_value()
? schedulerToolbox.bridgelessBindingsExecutor.value()
Expand Down
Loading