Update OkHttp to 3.3.1

[AndrewJack]

Motivation

Fixes: #7743

• Android apps can recover from a REFUSED_STREAM in HTTP/2.
• A few other fixes mentioned in the CHANGELOG.md

Test plan

• CircleCi
• Integrate into sample project (Project)

[ghost]

By analyzing the blame information on this pull request, we identified @mkonicek and @bestander to be potential reviewers.

[bestander]

ping when it is ready

[AndrewJack]

@bestander I have tested with a sample app and all seems to be fine.

The tests are failing with BUCK, but pass in the IDE and with Gradle.
I've tired changing a few BUCK config files but it doesn't seem to work. Do you have any idea?

[bestander]

The first exception is

FAILURE com.facebook.react.modules.network.NetworkingModuleTest testGetWithoutHeaders: 
java.lang.AssertionError
    at okhttp3.internal.AndroidPlatform.isCleartextTrafficPermitted(AndroidPlatform.java:143)
    at okhttp3.OkHttpClient.<clinit>(OkHttpClient.java:73)

I wonder if it is something system specific

[ghost]

@AndrewJack updated the pull request.

[AndrewJack]

I've updated this PR to upgrade to OkHttp 3.3.1.

Still stumped on the BUCK unit test errors

Most of the failures have this error:

java.lang.NoClassDefFoundError: okhttp3.OkHttpClient

[bestander]

This is the error:
okhttp3.internal.AndroidPlatform.isCleartextTrafficPermitted(AndroidPlatform.java:143)
Could it be emulator based?
We could bump to another version other than 19.

[AndrewJack]

Relates to this issue: square/okhttp#2533

and: robolectric/robolectric#2478

[mkonicek]

Good find @AndrewJack. Should we wait for a fix in OkHttp?

[AndrewJack]

Upgraded Robolectric to fix the issue, but 3.1 doesn't currently work with power mock.

Waiting for 3.1.1...
robolectric/robolectric#2429

[AndrewJack]

Closing this issue. #8672 fixes the issues we experienced when upgrading OkHttp to 3.3.1.

Also leaving Robolectric at 3.0