Make elementCallback idempotent if using a custom viewport width#350
Merged
Conversation
I hadn't realised this got called multiple times with the same node and it isn't currently idempotent so each time a component re-renders it re-wraps getBoundingClientRect, increasing the amount the returned rect is scaled by each time. Issue is only present if viewportScale !== 1 Fix captures the original getBoundingClientRect in a WeakMap so subsequent calls will re-use the original function when wrapping
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
workflow: benchmarks/perf (native)Comparison of performance test results, measured in operations per second. Larger is better.
|
necolas
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hadn't realised this got called multiple times with the same node and it isn't currently idempotent so each time a component re-renders it re-wraps getBoundingClientRect, increasing the amount the returned rect is scaled by each time.
Issue is only present if viewportScale !== 1
Fix captures the original getBoundingClientRect in a WeakMap so subsequent calls will re-use the original function when wrapping