Expose getters and setters for some new properties#192
Merged
Conversation
The properties include overflow and min/max height/width.
Contributor
|
Is min/max actually spec compliant? If yes, this would be huge! A lot of people have been waiting for that. |
Author
|
@vjeux it is not fully spec compliant. When resolving min/max sizes, section 9.7.4 of the spec calls for n passes whereas this only does 2 passes. The 2 pass approach was borrowed from code that was in css-layout prior to PR #185. I'm not familiar with how well the min/max implementation worked prior to PR #185. However, the current implementation has worked very well for our app. |
Contributor
|
Thank you! |
ghost
pushed a commit
to react/react-native
that referenced
this pull request
Jun 13, 2016
Summary: Import latest master from css-layout. This includes the following pull requests: react/yoga#192 react/yoga#193 react/yoga#195 react/yoga#196 Reviewed By: javache Differential Revision: D3411535 fbshipit-source-id: 95bee9bd0282f98f6fafa15335b910b644395ad3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #185 added support for some new properties. We forgot to include getters/setters for these properties in some of the languages. This PR fixes that.
The properties include overflow and min/max height/width.