Skip to content

Remove test build from publish artefects #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mayank1513 merged 2 commits into from
Oct 7, 2023
Merged

Remove test build from publish artefects #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53439c6
Remove test build from publish artefects
mayank1513 Oct 7, 2023
fae28e2
changeset
mayank1513 Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
with:
node-version: 18
registry-url: https://registry.npmjs.org
- run: npm i -g pnpm && pnpm i --ignore-scripts
- run: npm i -g pnpm && pnpm i
name: Install dependencies
- run: pnpm build --filter esbuild-plugin-react18-example
name: build example app to run tests
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,4 @@ yarn-error.log*

# build files
dist
test-build
6 changes: 6 additions & 0 deletions packages/esbuild-plugin-react18/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# esbuild-plugin-react18

## 0.0.5

### Patch Changes

- Remove test build files from publish artefects

## 0.0.4

### Patch Changes
Expand Down
4 changes: 2 additions & 2 deletions packages/esbuild-plugin-react18/__tests__/buildReplacePatterns.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import glob from "tiny-glob";
*/
describe.concurrent("Test plugin with ignorePatterns -- without content pattern", async () => {
const outDir = "build-replace-patterns";
const exampleBuildDir = path.resolve(process.cwd(), "dist", outDir);
const exampleBuildDir = path.resolve(process.cwd(), "test-build", outDir);
try {
fs.unlinkSync(path.resolve(exampleBuildDir));
} catch {}
Expand All @@ -37,7 +37,7 @@ describe.concurrent("Test plugin with ignorePatterns -- without content pattern"
entryPoints: await glob("../esbuild-plugin-react18-example/src/**/*.*"),
publicPath: "https://my.domain/static/",
external: ["react", "react-dom"],
outdir: "./dist/" + outDir,
outdir: "./test-build/" + outDir,
});
});

Expand Down
8 changes: 4 additions & 4 deletions packages/esbuild-plugin-react18/__tests__/ignorePatterns.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import glob from "tiny-glob";

describe.concurrent("Test plugin with ignorePatterns -- without content pattern", async () => {
const outDir = "ignore-patterns-0";
const exampleBuildDir = path.resolve(process.cwd(), "dist", outDir);
const exampleBuildDir = path.resolve(process.cwd(), "test-build", outDir);
try {
fs.unlinkSync(path.resolve(exampleBuildDir));
} catch {}
Expand All @@ -22,7 +22,7 @@ describe.concurrent("Test plugin with ignorePatterns -- without content pattern"
entryPoints: await glob("../esbuild-plugin-react18-example/src/**/*.*"),
publicPath: "https://my.domain/static/",
external: ["react", "react-dom"],
outdir: "./dist/" + outDir,
outdir: "./test-build/" + outDir,
});
});

Expand Down Expand Up @@ -59,11 +59,11 @@ describe.concurrent("Test plugin with ignorePatterns with content pattern", asyn
entryPoints: await glob("../esbuild-plugin-react18-example/src/**/*.*"),
publicPath: "https://my.domain/static/",
external: ["react", "react-dom"],
outdir: "./dist/" + outDir,
outdir: "./test-build/" + outDir,
});
});

const exampleBuildDir = path.resolve(process.cwd(), "dist", outDir);
const exampleBuildDir = path.resolve(process.cwd(), "test-build", outDir);
test(`star-me.tsx file should exist`, ({ expect }) => {
expect(fs.existsSync(path.resolve(exampleBuildDir, "client", "star-me", "star-me.js"))).toBe(
true,
Expand Down
4 changes: 2 additions & 2 deletions packages/esbuild-plugin-react18/__tests__/sourceReplacePatterns.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import glob from "tiny-glob";

describe.concurrent("Test plugin with ignorePatterns -- without content pattern", async () => {
const outDir = "source-replace-patterns";
const exampleBuildDir = path.resolve(process.cwd(), "dist", outDir);
const exampleBuildDir = path.resolve(process.cwd(), "test-build", outDir);
try {
fs.unlinkSync(path.resolve(exampleBuildDir));
} catch {}
Expand All @@ -34,7 +34,7 @@ describe.concurrent("Test plugin with ignorePatterns -- without content pattern"
entryPoints: await glob("../esbuild-plugin-react18-example/src/**/*.*"),
publicPath: "https://my.domain/static/",
external: ["react", "react-dom"],
outdir: "./dist/" + outDir,
outdir: "./test-build/" + outDir,
});
});

Expand Down
2 changes: 1 addition & 1 deletion packages/esbuild-plugin-react18/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "esbuild-plugin-react18",
"author": "Mayank Kumar Chaudhari <https://mayank-chaudhari.vercel.app>",
"private": false,
"version": "0.0.4",
"version": "0.0.5",
"description": "Unleash the Power of React Server Components! ESBuild plugin to build RSC (React18 Server Components) compatible libraries.",
"main": "dist/index.js",
"types": "dist/index.d.ts",
Expand Down