Skip to content

Fix-jsx-dedup #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mayank1513 merged 2 commits into from
Jun 2, 2024
Merged

Fix-jsx-dedup #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
261fbd3
Do not remove ';' when require statement starts with ','.
mayank1513 Jun 2, 2024
97ccace
Apply changesets
mayank1513 Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# esbuild-plugin-react18

## 0.2.4

### Patch Changes

- Do not remove ';' when require statement starts with ','.

## 0.2.3

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "esbuild-plugin-react18",
"author": "Mayank Kumar Chaudhari <https://mayank-chaudhari.vercel.app>",
"private": false,
"version": "0.2.3",
"version": "0.2.4",
"description": "Unlock the Potential of React Server Components! Harness the power of an ESBuild plugin designed for crafting libraries compatible with RSC (React18 Server Components).",
"license": "MPL-2.0",
"main": "./dist/index.js",
Expand Down
3 changes: 2 additions & 1 deletion lib/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ function onEndCallBack(result: BuildResult, options: React18PluginOptions, write
for (let index = 1; index < jsxMatches.length; index++) {
let token = jsxMatches[index];
if (/^,.*,$/.test(token)) token = token.slice(1);
else if (token.startsWith("var ") && token.endsWith(",")) token = token.slice(4);
else if (/^,.*;$/.test(token)) token = token.replace(";", "");
else if (/^var .*,$/.test(token)) token = token.slice(4);
txt = txt.replace(token, "");
const v1 = jsxMatches[index]
.replace(regExp2replace2GetVar, "")
Expand Down