Add Roslyn 5.0 support to source generators #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new ReactiveUI.SourceGenerators.Roslyn5000 project targeting Roslyn 5.0, updates conditional compilation to support ROSYLN_500, and integrates the new project into the solution and main source generators package. This enables compatibility with the latest Roslyn compiler and ensures proper packaging of analyzers for Roslyn 5.0.
Extended conditional compilation to include ROSYLN_500 in attribute and generator logic. Updated README to clarify partial property initializer support now requires C# 14 or newer.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
=======================================
Coverage 43.22% 43.22%
=======================================
Files 64 64
Lines 3646 3646
Branches 420 420
=======================================
Hits 1576 1576
Misses 1950 1950
Partials 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glennawatson
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fixes #359
What is the current behavior?
#359
What is the new behavior?
Introduces a new ReactiveUI.SourceGenerators.Roslyn5000 project targeting Roslyn 5.0, updates conditional compilation to support ROSYLN_500, and integrates the new project into the solution and main source generators package.
This enables compatibility with the latest Roslyn compiler and ensures proper packaging of analyzers for Roslyn 5.0.
What might this PR break?
Same functions new Roslyn target.
Please check if the PR fulfills these requirements
Other information: