Normalize aria-labels on TeamMember social links - #8592
Conversation
Twitter, Threads, and Bluesky links already included the member's
name in their aria-label, but GitHub and personal-site links used
generic labels ("GitHub Profile", "Personal Site") with no name —
inconsistent and confusing for screen reader users scanning the
team page. Standardize all five link types to include the member's
name, and mark their icons aria-hidden since the link's accessible
name already conveys the same information.
Fixes reactjs#8552
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
2 participants
Fixes #8552.
Twitter, Threads, and Bluesky links in TeamMember.tsx already included the member's name in their aria-label (e.g. "${name} on Twitter"), but the GitHub and personal-site links used generic, unqualified labels ("GitHub Profile", "Personal Site"). On the team page, which lists many members, that inconsistency makes it hard for screen reader users to tell whose link they are on when navigating by link/landmark.
This PR:
No visual changes; prettier --check passes on the changed file.