translate Thinking in React #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 tasks
lex111
reviewed
Feb 11, 2019
angryermine
reviewed
Feb 12, 2019
INQTR
reviewed
Feb 12, 2019
angryermine
reviewed
Feb 12, 2019
gaearon
requested changes
Feb 12, 2019
Member
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Спасибо, надо поправить пару вещей
gaearon
requested changes
Feb 12, 2019
Member
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Хорошо! Есть одна претензия, которая по всему тексту — надо упростить сложные предложения
|
|
||
| But how do you know what should be its own component? Just use the same techniques for deciding if you should create a new function or object. One such technique is the [single responsibility principle](https://en.wikipedia.org/wiki/Single_responsibility_principle), that is, a component should ideally only do one thing. If it ends up growing, it should be decomposed into smaller subcomponents. | ||
| Но как узнать, что является компонентом, а что нет? Всё очень просто: это похоже на то, как вы решаете, надо ли объявить функцию или объект. Один из таких методов — [принцип единственной ответственности](https://ru.wikipedia.org/wiki/Принцип_единственной_ответственности), суть которого состоит в том, что в идеале компонент должен выполнять только одну поставленную задачу. Если в конечном итоге функционал компонента увеличивается, его следует разбить на более мелкие подкомпоненты. | ||
|
|
Member
There was a problem hiding this comment.
То же самое — упрощайте и разбивайте длинные предложения
another-guy
added
work in progress
lex111
reviewed
Feb 13, 2019
Co-Authored-By: marichka-offen <40467112+marichka-offen@users.noreply.github.com>
gaearon
approved these changes
Feb 13, 2019
Member
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Очень хорошо. Поправил мелочи. Спасибо.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.