Closed
Conversation
WyriHaximus
approved these changes
Jul 10, 2020
jsor
approved these changes
Jul 11, 2020
clue
reviewed
Aug 13, 2020
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@akondas Thanks for looking into this!
The suggested changes LGTM, but they only contain the parsing (receiving) side and currently omit the serializing (sending) part. Accordingly, this should also update the documentation in the Record class. You can take a look at #141/#142 and others for inspiration.
Can you look into this? 👍
Contributor
Author
|
Sure, no problem 😉 |
Member
|
@akondas Ping, any updates on this? We're planning the next DNS release and we like to get this in |
Contributor
Author
|
Sorry, somehow it slipped out of my head. What is the deadline? |
Member
|
There is no hard date, in fact, we just released |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite the fact that this record is already deprecated, we need to check if it exists at all (for example when validating user spf record).
RFC: https://tools.ietf.org/html/rfc4408#section-3.1.1