Skip to content

[3.x] Improve PHP 8.5+ support by avoiding deprecated method calls #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clue merged 4 commits into from
Nov 17, 2025
Merged

[3.x] Improve PHP 8.5+ support by avoiding deprecated method calls #281

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
941af79
[3.x] Run CI jobs on PHP8.5
WyriHaximus Nov 8, 2025
5d698a2
[3.x] Fix ext-uv int into float overflow logic for PHP8.5
WyriHaximus Nov 8, 2025
d1a83a2
[3.x] Fix reflection setAccessible deprecatoin warnings
WyriHaximus Nov 8, 2025
143445e
[3.x] Fix SPL SplObjectStorage deprecations
WyriHaximus Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[3.x] Fix reflection setAccessible deprecatoin warnings 
In PHP8.1 ReflectionProperty::setAccessible was made a no-op through https://wiki.php.net/rfc/make-reflection-setaccessible-no-op in PHP8.5 it is now throwing a deprecation warning by: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_reflectionsetaccessible
  • Loading branch information
@WyriHaximus
WyriHaximus committed Nov 8, 2025
commit d1a83a2e777c04a8e7357f7c86ab7307cc89d78e
52 changes: 39 additions & 13 deletions tests/LoopTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ public function testStaticAddReadStreamCallsAddReadStreamOnLoopInstance()
public function testStaticAddReadStreamWithNoDefaultLoopCallsAddReadStreamOnNewLoopInstance()
{
$ref = new \ReflectionProperty(Loop::class, 'instance');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$ref->setValue(null, null);

$stream = stream_socket_server('127.0.0.1:0');
Expand All @@ -68,7 +70,9 @@ public function testStaticAddWriteStreamCallsAddWriteStreamOnLoopInstance()
public function testStaticAddWriteStreamWithNoDefaultLoopCallsAddWriteStreamOnNewLoopInstance()
{
$ref = new \ReflectionProperty(Loop::class, 'instance');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$ref->setValue(null, null);

$stream = stream_socket_server('127.0.0.1:0');
Expand All @@ -93,7 +97,9 @@ public function testStaticRemoveReadStreamCallsRemoveReadStreamOnLoopInstance()
public function testStaticRemoveReadStreamWithNoDefaultLoopIsNoOp()
{
$ref = new \ReflectionProperty(Loop::class, 'instance');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$ref->setValue(null, null);

$stream = tmpfile();
Expand All @@ -117,7 +123,9 @@ public function testStaticRemoveWriteStreamCallsRemoveWriteStreamOnLoopInstance(
public function testStaticRemoveWriteStreamWithNoDefaultLoopIsNoOp()
{
$ref = new \ReflectionProperty(Loop::class, 'instance');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$ref->setValue(null, null);

$stream = tmpfile();
Expand Down Expand Up @@ -145,7 +153,9 @@ public function testStaticAddTimerCallsAddTimerOnLoopInstanceAndReturnsTimerInst
public function testStaticAddTimerWithNoDefaultLoopCallsAddTimerOnNewLoopInstance()
{
$ref = new \ReflectionProperty(Loop::class, 'instance');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$ref->setValue(null, null);

$interval = 1.0;
Expand Down Expand Up @@ -175,7 +185,9 @@ public function testStaticAddPeriodicTimerCallsAddPeriodicTimerOnLoopInstanceAnd
public function testStaticAddPeriodicTimerWithNoDefaultLoopCallsAddPeriodicTimerOnNewLoopInstance()
{
$ref = new \ReflectionProperty(Loop::class, 'instance');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$ref->setValue(null, null);

$interval = 1.0;
Expand All @@ -202,7 +214,9 @@ public function testStaticCancelTimerCallsCancelTimerOnLoopInstance()
public function testStaticCancelTimerWithNoDefaultLoopIsNoOp()
{
$ref = new \ReflectionProperty(Loop::class, 'instance');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$ref->setValue(null, null);

$timer = $this->createMock(TimerInterface::class);
Expand All @@ -226,7 +240,9 @@ public function testStaticFutureTickCallsFutureTickOnLoopInstance()
public function testStaticFutureTickWithNoDefaultLoopCallsFutureTickOnNewLoopInstance()
{
$ref = new \ReflectionProperty(Loop::class, 'instance');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$ref->setValue(null, null);

$listener = function () { };
Expand Down Expand Up @@ -255,7 +271,9 @@ public function testStaticAddSignalWithNoDefaultLoopCallsAddSignalOnNewLoopInsta
}

$ref = new \ReflectionProperty(Loop::class, 'instance');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$ref->setValue(null, null);

$signal = 1;
Expand Down Expand Up @@ -285,7 +303,9 @@ public function testStaticRemoveSignalCallsRemoveSignalOnLoopInstance()
public function testStaticRemoveSignalWithNoDefaultLoopIsNoOp()
{
$ref = new \ReflectionProperty(Loop::class, 'instance');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$ref->setValue(null, null);

$signal = 1;
Expand All @@ -308,7 +328,9 @@ public function testStaticRunCallsRunOnLoopInstance()
public function testStaticRunWithNoDefaultLoopCallsRunsOnNewLoopInstance()
{
$ref = new \ReflectionProperty(Loop::class, 'instance');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$ref->setValue(null, null);

Loop::run();
Expand All @@ -329,7 +351,9 @@ public function testStaticStopCallsStopOnLoopInstance()
public function testStaticStopCallWithNoDefaultLoopIsNoOp()
{
$ref = new \ReflectionProperty(Loop::class, 'instance');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$ref->setValue(null, null);

Loop::stop();
Expand All @@ -344,7 +368,9 @@ public function testStaticStopCallWithNoDefaultLoopIsNoOp()
public function unsetLoopFromLoopAccessor()
{
$ref = new \ReflectionProperty(Loop::class, 'instance');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$ref->setValue(null, null);
}
}
Loading