Skip to content

Simplify usage by supporting new default loop #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clue merged 3 commits into from
Jul 11, 2021
Merged

Simplify usage by supporting new default loop #410

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5417e83
Simplify usage by supporting new default loop
clue Jul 8, 2021
6b1a826
Update to stable reactphp/event-loop v1.2.0 & updated stream and socket
clue Jul 8, 2021
d9401a5
Work around failing tests on legacy PHP 5.3
clue Jul 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Work around failing tests on legacy PHP 5.3
  • Loading branch information
@clue
clue committed Jul 11, 2021
commit d9401a5c1be1ed967ee4d94187371cedfe1e8d85
6 changes: 6 additions & 0 deletions tests/Client/FunctionalIntegrationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ public function testRequestLegacyHttpServerWithOnlyLineFeedReturnsSuccessfulResp
/** @group internet */
public function testSuccessfulResponseEmitsEnd()
{
// max_nesting_level was set to 100 for PHP Versions < 5.4 which resulted in failing test for legacy PHP
ini_set('xdebug.max_nesting_level', 256);

$loop = Factory::create();
$client = new Client($loop);

Expand All @@ -106,6 +109,9 @@ public function testPostDataReturnsData()
$this->markTestSkipped('Not supported on HHVM');
}

// max_nesting_level was set to 100 for PHP Versions < 5.4 which resulted in failing test for legacy PHP
ini_set('xdebug.max_nesting_level', 256);

$loop = Factory::create();
$client = new Client($loop);

Expand Down