Skip to content

Improve test suite to skip memory tests when lowering memory limit does not work #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WyriHaximus merged 1 commit into from
Feb 5, 2022
Merged

Improve test suite to skip memory tests when lowering memory limit does not work #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Skip memory tests when lowering memory limit does not work
  • Loading branch information
@clue
clue committed Feb 4, 2022
commit 83162766662e19f3367d8d30da41e1c07c39c5b9
4 changes: 3 additions & 1 deletion tests/HttpServerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,9 @@ public function testConstructServerWithUnlimitedMemoryLimitDoesNotLimitConcurren
public function testConstructServerWithMemoryLimitDoesLimitConcurrency()
{
$old = ini_get('memory_limit');
ini_set('memory_limit', '100M');
if (@ini_set('memory_limit', '128M') === false) {
$this->markTestSkipped('Unable to change memory limit');
}

$http = new HttpServer(function () { });

Expand Down