Added React Todo Application#100
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/atapas/react-play/EbQLckCE769pmdoMyRcpY3r1R1ea |
|
@atapas review it Sir |
atapas
left a comment
There was a problem hiding this comment.
@nirban256 mostly looks good. Please take care of the review comments to get it merged asap.
atapas
left a comment
There was a problem hiding this comment.
@nirban256 A few more comments about the styling.
|
I suggest not adding a todo if the input has no value. |
Yes I have provided that comment too. |
|
@atapas I have removed the local Storage functionality as it was not working and made the other changes, but couldn't change the page level scroll |
atapas
left a comment
There was a problem hiding this comment.
@nirban256 A few more cosmetic changes.
|
made the changes @atapas Sir |
atapas
left a comment
There was a problem hiding this comment.
Just one more comment I gave and
DO NOT COMMIT the yarn.lock file as there are no changes in the package.json file.
|
I added the yarn.lock in the gitignore file and made the change. Is it correct now? @atapas |
Yes that's right.. add it in .gitignore but also do not push your yarn lock file... |
|
@atapas Can you tell me how can I not push the yarn.lock file? |
I shall remove it in a different PR |
Description: Added a React Todo Application which keeps track of daily todos that need to be done.
Fixes # (issue) : 91
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: