Skip to content

chore: add meetup link icon in the footer#1437

Merged
priyankarpal merged 5 commits intoreactplay:mainfrom
Meetverma:main
Feb 15, 2024
Merged

chore: add meetup link icon in the footer#1437
priyankarpal merged 5 commits intoreactplay:mainfrom
Meetverma:main

Conversation

@Meetverma
Copy link
Copy Markdown
Contributor

@Meetverma Meetverma commented Feb 7, 2024 •
edited by priyankarpal
Loading

Description

Added a meetup link button in the footer

Fixes #1434

Type of change

  • [Y] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally and Works Fine!

Checklist:

  • [Y] I have performed a self-review of my own code
  • [Y] My changes generate no new warnings
  • [Y] New and existing unit tests pass locally with my changes

Screenshots or example output

Screenshot 2024-02-07 at 7 12 35 PM

@Meetverma
<header>
d8fe1c2 
fixes#1413
<body>
added Meetup logo in footer
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 7, 2024 •
edited
Loading

✅ Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 1fd24c3
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/65ce1ba4ef7aca0008fa5311
😎 Deploy Preview https://deploy-preview-1437--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Feb 7, 2024
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@Meetverma Meetverma mentioned this pull request Feb 7, 2024
Closed
@priyankarpal
Copy link
Copy Markdown
Member

priyankarpal commented Feb 14, 2024

Hello @Meetverma, please refrain from making these types of commits in the future

header

priyankarpal
priyankarpal requested changes Feb 14, 2024
View reviewed changes
@priyankarpal priyankarpal added the changes required need to change some thing label Feb 14, 2024
atapas
atapas previously approved these changes Feb 14, 2024
View reviewed changes
@priyankarpal
Merge branch 'main' into main
d479ad4 
Signed-off-by: Priyankar Pal <88102392+priyankarpal@users.noreply.github.com>
@priyankarpal priyankarpal added chore and removed waiting for reviewers changes required need to change some thing labels Feb 15, 2024
@priyankarpal priyankarpal changed the title feat:add meetup link icon in the footer chore: add meetup link icon in the footer Feb 15, 2024
@priyankarpal priyankarpal merged commit 8381885 into reactplay:main Feb 15, 2024
@Meetverma
Copy link
Copy Markdown
Contributor Author

Meetverma commented Feb 15, 2024

Thanks @priyankarpal
That Was my first commit to react-play...
Looking forward for more contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@priyankarpal priyankarpal priyankarpal approved these changes

@atapas atapas atapas left review comments

Assignees

@Meetverma Meetverma

Labels

chore ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: add our meetup link icon in the footer

3 participants

@Meetverma @priyankarpal @atapas