Cancel btn text fix issue #157#158
Closed
ashutoshdhande wants to merge 1 commit intoreactplay:mainfrom
ashutoshdhande:css-fixes-ashutosh
Closed
Cancel btn text fix issue #157#158ashutoshdhande wants to merge 1 commit intoreactplay:mainfrom ashutoshdhande:css-fixes-ashutosh
ashutoshdhande wants to merge 1 commit intoreactplay:mainfrom
ashutoshdhande:css-fixes-ashutosh
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel. @atapas first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
@nirmalkc Could you please review this PR? |
nirmalkc
previously approved these changes
May 12, 2022
Collaborator
|
Please change the CSS class names in search.css from '.btn-default' to 'btn-default-light' in all the 3 instances shown below (203, 217, 218).
Also, do the same change in common/modal/index.jsx.
Also, please remove .btn-cancel in index.jsx as well as from the playideas.css. Thanks |
atapas
requested changes
May 12, 2022
Member
atapas
left a comment
atapas
left a comment
There was a problem hiding this comment.
@ashutoshdhande plz take care of the comments
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue is fixed by adding extra class and defining it, to avoid clashes with
btn-defaultstyles if used in futureFixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Refer to image below
Checklist: