a Simple and Fun Quiz App

[Angryman18]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

• I have performed a self-review of my own code
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[vercel]

Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel.

@atapas first needs to authorize it.

[Angryman18]

Its really a dirty work and dirty code also.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
react-play	✅ Ready (Inspect)	Visit Preview	May 21, 2022 at 6:09AM (UTC)

[MOHAMED-EHAB-DEV]

Very Amazing

[atapas]

This is one of the most incredible play I've seen! I shall start doing code reviews soon.

[MOHAMED-EHAB-DEV]

This is one of the most incredible play I've seen! I shall start doing code reviews soon.

Give me the reviewing and merging i am free

[Angryman18]

This is one of the most incredible play I've seen! I shall start doing code reviews soon.

Thanks. I see a bug. Will fix at next push.

[Angryman18]

sorry i was mistaken about the bug. i think its working good. although i fixed a "key" was missing while mapping array.

[atapas]

@Angryman18 Could you please create an issue for the play and associate with the PR to start the review?

[Angryman18]

@Angryman18 Could you please create an issue for the play and associate with the PR to start the review?

Created sir.

[atapas]

@Angryman18 Could you please create an issue for the play and associate with the PR to start the review?

Created sir.

Thanks but it was not done correctly.

So next time,

• You need to create a play request if it is a play, else a bug or feature.
• After creating the issue you can attach it to a PR(if already exist) from the right side setting of an issue.

[Angryman18]

ah. sorry about that. not very good on github yet but i learned a lot in recent days.

[atapas]

This is one of the most incredible play I've seen! I shall start doing code reviews soon.

Give me the reviewing and merging i am free

Please go ahead and finish the review

[MOHAMED-EHAB-DEV]

LGTM

[atapas]

LGTM

Thanks, @koustov please finish your review too.

[koustov]

Started reviewing. I will finish it soon.

[koustov]

@Angryman18 this is a great play ❤. I am fully energized to see the granularity maintained here.

[Angryman18]

ok i will fix by night

[koustov]

some questions added. also please notify once you are done with all comments.

[atapas]

i dont see any issue with hover. we only want to show pointer when its hovered. so eitherway it works the same. and i believe only questions would be coming from the api so i didnt add additional validiation there. and for nullable, i dont understand if you are talking about current question if so then current question cannot be null. its defined with a value and some certain conditions are applied for updating it's value (when timer gets timed out or user clicks "confirm" button or at veryfirst clicking "Let start" button).

Look like we are close to getting done with the comments. Can't wait to see this one crossing the border...

@Angryman18 @koustov

[koustov]

@Angryman18 is it ready to be reviewed one last time?

Note: Please reply to every comment. In fact, if you disagree with the suggestion given, just respond with reasoning. I want to resolve all conversations before approving any PR, this will be really helpful for any future tracking.

[Angryman18]

i think the required changes are made.

[koustov]

LGTM