[Feature] Added feature to allow users to select preferred styling lang#209
Merged
atapas merged 4 commits intoreactplay:mainfrom May 21, 2022
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
This is Ready for Review :) |
atapas
requested changes
May 21, 2022
Member
atapas
left a comment
There was a problem hiding this comment.
Thanks @naiknareshh for picking this up.
Review comments given.
If you could post some screenshots of your testing would be great.
Additionally, you need to update the CREATE PLAY Read me file to include this option and change the screenshot there. Please check https://github.com/atapas/react-play/blob/main/CREATE-PLAY.md#%EF%B8%8F-steps-to-create-a-play
efba61d to
8479c97
Compare
Contributor
Author
Testing StepsStep 1: Validate 'Style to be used' question is queued up as expectedStep 2: Validate the files are getting created as expected and without any errors in the consoleStep 3: Validate proper import statement is added in the JSX fileStep 4: Add some styles to some existing elementStep 5: Validate the styles are reflected properly on the play without any issues |
Contributor
Author
|
@atapas All comments have been incorporated, please review and let me know if there is anything. |
Member
|
@all-contributors please add @naiknareshh for Code |
Contributor
|
I've put up a pull request to add @naiknareshh! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This feature allows user to select preferred styling language while creating the play. an empty 'css' or 'scss' file will be automatically added in their play directory based on the selection. No dependencies were added for this change.
Fixes #205
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: