Fix 🐛 Bug #479: The Console has bunch of warnings by Sachin-chaurasiya · Pull Request #480 · reactplay/react-play

Sachin-chaurasiya · 2022-08-11T11:51:57Z

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

I worked on fixing issue #479

Fixes #479

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

vercel · 2022-08-11T11:51:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
react-play	✅ Ready (Inspect)	Visit Preview	Aug 30, 2022 at 7:44AM (UTC)

koustov

Few initial question dropped

src/common/services/request/index.js

src/common/playlists/PlayList.jsx

src/common/services/string.js

src/plays/context-with-real-usecases/ContextWithRealUsecases.jsx

src/plays/countries-statics/Country.jsx

src/common/services/request/index.js

src/common/playlists/PlayList.jsx

src/common/services/string.js

src/plays/context-with-real-usecases/ContextWithRealUsecases.jsx

src/plays/countries-statics/Country.jsx

koustov

lgtm

koustov · 2022-08-20T19:37:16Z

Crawler error

atapas · 2022-08-22T06:21:14Z

Crawler error

Yep, very surprisingly, it never passes.

atapas · 2022-08-23T03:28:28Z

@Sachin-chaurasiya Any idea on it? I am clueless why this branch alone fails to build!

Sachin-chaurasiya · 2022-08-23T04:56:10Z

@Sachin-chaurasiya Any idea on it? I am clueless why this branch alone fails to build!

Hey @atapas , I will have a look and if not working then will close this PR and open a new PR with the changes.

koustov · 2022-08-23T18:32:48Z

@Sachin-chaurasiya Any idea on it? I am clueless why this branch alone fails to build!

Hey @atapas , I will have a look and if not working then will close this PR and open a new PR with the changes.

It might be because of the dependency array. I can see the quoteArray is using a spread operator so its always a new instance. @Sachin-chaurasiya can you just remove the dependency and push once

Sachin-chaurasiya · 2022-08-24T04:48:41Z

@Sachin-chaurasiya Any idea on it? I am clueless why this branch alone fails to build!

Hey @atapas , I will have a look and if not working then will close this PR and open a new PR with the changes.

It might be because of the dependency array. I can see the quoteArray is using a spread operator so its always a new instance. @Sachin-chaurasiya can you just remove the dependency and push once

@koustov , quoteArray is being used in that effect so we should have that in dependency right? it does not matter how we are using the quoteArray, only thing matter is what variable we are using for that effect.
If you want I can remove that but eslint will be complaining :)

koustov · 2022-08-24T18:24:14Z

quoteArray is being used in that effect so we should have that in dependency right?

I didn't try by myself however looking at the error (time out) I can only suspect something is blocking the crawler from passing through the component. It's my educated guess that the quotearray might be the issue. So what I am suggesting is, to remove the dependency and push a commit, if the crawler passes we know what was wrong and then we can take appropriate measurements before getting the PR merge. So, it's just a TRY, nothing more than that

Sachin-chaurasiya · 2022-08-25T09:35:19Z

quoteArray is being used in that effect so we should have that in dependency right?

I didn't try by myself however looking at the error (time out) I can only suspect something is blocking the crawler from passing through the component. It's my educated guess that the quotearray might be the issue. So what I am suggesting is, to remove the dependency and push a commit, if the crawler passes we know what was wrong and then we can take appropriate measurements before getting the PR merge. So, it's just a TRY, nothing more than that

Sure, I will try that.

…nto issue-479

Sachin-chaurasiya · 2022-08-27T14:30:21Z

Hey @koustov , Thanks man, after removing quoteArray from dependency it's working.

koustov

lgtm

Sachin-chaurasiya · 2022-08-30T07:40:43Z

@atapas , Waiting for your review.

Fix 🐛 Bug #479: The Console has bunch of warnings

033bc5c

Sachin-chaurasiya added the review ready label Aug 11, 2022

Sachin-chaurasiya requested review from atapas and koustov as code owners August 11, 2022 11:51

Sachin-chaurasiya self-assigned this Aug 11, 2022

vercel bot deployed to Preview August 11, 2022 11:52 View deployment

koustov requested changes Aug 12, 2022

View reviewed changes

koustov requested changes Aug 13, 2022

View reviewed changes

Sachin-chaurasiya added 2 commits August 14, 2022 13:34

Merge branch 'main' into issue-479

0cd7459

Addressing review comments

1ee5633

vercel bot had a problem deploying to Preview August 14, 2022 08:12 Failure

Fix spacing issue

37530dd

vercel bot had a problem deploying to Preview August 14, 2022 08:18 Failure

Merge branch 'main' into issue-479

110d369

vercel bot had a problem deploying to Preview August 15, 2022 07:56 Failure

Merge branch 'main' into issue-479

edac552

vercel bot had a problem deploying to Preview August 15, 2022 08:14 Failure

Merge branch 'main' into issue-479

94ef9d1

vercel bot had a problem deploying to Preview August 16, 2022 14:27 Failure

Merge branch 'main' into issue-479

fd9571c

vercel bot had a problem deploying to Preview August 19, 2022 14:57 Failure

koustov previously approved these changes Aug 20, 2022

View reviewed changes

Merge branch 'main' into issue-479

f110b14

vercel bot had a problem deploying to Preview August 21, 2022 06:04 Failure

Merge branch 'main' into issue-479

b9a2fdb

vercel bot had a problem deploying to Preview August 22, 2022 06:23 Failure

Merge branch 'main' into issue-479

8d2851a

vercel bot had a problem deploying to Preview August 22, 2022 10:24 Failure

Merge branch 'main' into issue-479

93ab8e2

vercel bot had a problem deploying to Preview August 25, 2022 09:39 Failure

Sachin-chaurasiya added 2 commits August 26, 2022 16:18

Remove quoteArray from dependency

ad7ce9f

Merge branch 'issue-479' of https://github.com/reactplay/react-play i…

5347ace

…nto issue-479

Sachin-chaurasiya dismissed koustov’s stale review via 5347ace August 26, 2022 10:49

vercel bot deployed to Preview August 26, 2022 10:53 View deployment

Sachin-chaurasiya requested a review from koustov August 27, 2022 03:15

Merge branch 'main' into issue-479

35c7b48

vercel bot deployed to Preview August 27, 2022 14:27 View deployment

koustov approved these changes Aug 28, 2022

View reviewed changes

Merge branch 'main' into issue-479

4d973ff

vercel bot deployed to Preview August 29, 2022 03:56 View deployment

Merge branch 'main' into issue-479

b02db55

vercel bot deployed to Preview August 30, 2022 07:44 View deployment

atapas approved these changes Aug 30, 2022

View reviewed changes

atapas merged commit 8a5aac2 into main Aug 30, 2022

atapas deleted the issue-479 branch August 30, 2022 09:06

Uh oh!

Conversation

Sachin-chaurasiya commented Aug 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

vercel bot commented Aug 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

koustov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

koustov left a comment

Choose a reason for hiding this comment

Uh oh!

koustov commented Aug 20, 2022

Uh oh!

atapas commented Aug 22, 2022

Uh oh!

atapas commented Aug 23, 2022

Uh oh!

Sachin-chaurasiya commented Aug 23, 2022

Uh oh!

koustov commented Aug 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sachin-chaurasiya commented Aug 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

koustov commented Aug 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sachin-chaurasiya commented Aug 25, 2022

Uh oh!

Sachin-chaurasiya commented Aug 27, 2022

Uh oh!

koustov left a comment

Choose a reason for hiding this comment

Uh oh!

Sachin-chaurasiya commented Aug 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sachin-chaurasiya commented Aug 11, 2022 •

edited

Loading

vercel bot commented Aug 11, 2022 •

edited

Loading

koustov commented Aug 23, 2022 •

edited

Loading

Sachin-chaurasiya commented Aug 24, 2022 •

edited

Loading

koustov commented Aug 24, 2022 •

edited

Loading