feature: configured ESLint/Prettier/Husky setup#507
Merged
Sachin-chaurasiya merged 26 commits intorelease/code-cleanupfrom Nov 25, 2022
Merged
feature: configured ESLint/Prettier/Husky setup#507Sachin-chaurasiya merged 26 commits intorelease/code-cleanupfrom
Sachin-chaurasiya merged 26 commits intorelease/code-cleanupfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Member
|
Hey @joshi-kaushal i would like to get this PR in. A long-time one. Could you please resolve the conflict and fix the build error? Then it will be ready for merge. |
Member
Author
|
Hello @koustov, I am busy with a few other things rn. It would be really helpful if anyone could help me with this pr. |
Member
Author
|
Hi @koustov I can not see the preview or error log for this build. Where can I see those? |
11 tasks
Member
Author
|
Member
Nice! Can we put dates also on these tasks by when we can tentatively complete them? |
❌ Deploy Preview for reactplayio failed.
|
This reverts commit 1fd1dba.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fixes #263
I previously raised a similar PR #332, but this is the latest and better version of the issue.
This PR integrates Husky, Prettier, and ESLint with the repository. This will test staged files against the config before every commit.
The existing files are yet to be fixed. I believe in creating a different branch and collaboratively resolving those errors/warnings for doing it.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: