Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/atapas/react-play/2xJAa8j6T2CcshQQVp4DVwJHAJGZ |
atapas
left a comment
There was a problem hiding this comment.
Do not commit package lock file., yarn lock enough.
|
Hello @erayalkis We have upgraded to React v18 as part of this issue: #87 We have tested the existing plays. All good. Please pull this change to your branch and keep it up-to-date. You have to do sanity of things to make sure everything works for your changes in your branch. Happy Coding! |
|
I'm on it! Will ensure that everything works and push the updated version ASAP |
|
All done, everything works as intended! |
Will start a final review soon. Thanks! |
@erayalkis I have a question. How did you test the changes?
If you could post the screenshots, it helps me reducing the test of it. |
|
Alrighty! I'm so glad I could help! |
|
@all-contributors please add @erayalkis for Code |
|
I've put up a pull request to add @erayalkis! 🎉 |
If you share your experience on Twitter, don't forget to tag ReactPlayIO :) |
|
Will do! :) |




Description
This Pull Request implements dynamic meta tags for all plays using react-helmet.
Fixes #76
Type of change
How Has This Been Tested?
Inspecting the section in the document inspector or copying and pasting the current url into a platform that supports embeds should let anyone test the new functionality.
On a local server though, you will have to use an external browser extension to verify that the meta tags are working as expected.
I didn't write any tests or make any changes to the documentation, as I didn't think it was necessary.
Checklist:
Notes:
I should mention that while I was testing the meta tags on localhost, I had to provide full paths for the meta tag (ex: "www.reactplay.io/static/exampleimage12345.png"), and I removed the domain from url before the final commit. If this causes the meta image to not work it should be super easy to fix, but I just thought I should note it down here.
I hope the new changes are good, let me know if I need to anything else !!