Creation date added to Play header#960
Merged
atapas merged 17 commits intoreactplay:mainfrom Feb 26, 2023
Merged
Conversation
|
@ankitk26 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
@ankitk26 The build fails |
Contributor
Author
|
I will push the changes after fixing the error soon |
Member
|
@koustov Can you please review this one? |
Member
…into creation-date
Contributor
Author
|
Hi @atapas, I ran the yarn build command and it created the build folder without any errors. |
❌ Deploy Preview for reactplayio failed.
|
Member
|
@ankitk26 Finally it got built. A small comment on it. I see the vertical alignment of the dot, and the date is a bit off. Can you please fix that for merge? |
atapas
approved these changes
Feb 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Creation date for any play was added to the PlayHeader component. The date-fns library was used to get the locale-aware format of the date.
Fixes #862
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Different locale formats were added manually to check the right format of the date.
Checklist:
Screenshots or example output