Update Meta tags to use explicit URLs#99
Merged
atapas merged 6 commits intoreactplay:mainfrom Apr 24, 2022
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/atapas/react-play/A4DUzZstedx2yyrMgGzj6rJYV6RY |
Member
|
@erayalkis has it been tested with all scenarios? |
atapas
approved these changes
Apr 24, 2022
Collaborator
Author
Yep! Pushed all changes to Vercel and tested with all edge cases I could think of! I'll delete the Vercel app soon as we no longer need it, but you can test the changes here if you want: https://react-play-hazel.vercel.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed a few minutes ago that the meta tags we use don't work properly on some sites/apps.
This PR makes it so that the image URLs used for the meta tages are explicit(includes the full URL). This change was made because some sites do not behave as expected with the old URLs we were using, causing images to not appear on them. Changing it to an explicit URL got the results we wanted though!
I did not open an issue for this PR as it was a simple change but I can do so if you need me to!
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I tested this using external browser extensions and by pushing to Vercel and testing link embeds for various Plays.
Checklist:
Notes:
This should be the final fix to the meta tag problem! It's been fun figuring out how to implement this feature, thank you for the amazing opportunity! :)