Draft of wrapping more LCP license functionality into the library instead of handlers.#321
Draft
tm-bookshop wants to merge 4 commits intoreadium:masterfrom
Draft
Draft of wrapping more LCP license functionality into the library instead of handlers.#321tm-bookshop wants to merge 4 commits intoreadium:masterfrom
tm-bookshop wants to merge 4 commits intoreadium:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal: Wrap more of the functionality of LCP server into exported functions that can be used as a library from other Go services.
For example it seems useful to wrap validation things like
checkGetLicenseInput,copyInputToLicense,buildLicense, etc inside a single, exported function that can be called from outside an HTTP handler.Context:
Some other changes in this PR:
Errorthat wraps more detailed input-validation error messages