Set COMPOSE_PROJECT_NAME when invoking docker-compose#145
Set COMPOSE_PROJECT_NAME when invoking docker-compose#145benjaoming wants to merge 1 commit intoreadthedocs:mainfrom
Conversation
|
Reminder to update readthedocs/readthedocs.org#9319 after this is merged |
dbeb789 to
fe20078
Compare
humitos
left a comment
There was a problem hiding this comment.
I commented on readthedocs/readthedocs.org#9319 (comment) about how to solve this without introducing this change.
I prefer if we can read this automatically from the .env file so we can keep the current setup working together with corporate Docker instances.
|
Re:
I'll make a check to see if/how this works, but did you notice that the patch does not propose to overwrite existing env variables? DOCKER_COMPOSE_PROJECT_NAME = os.environ.get('COMPOSE_PROJECT_NAME', 'community') |
|
Yes. It seems this PR is not required anymore now that #148 got merged. |
|
Agreed - the I found a segment in the Compose docs that specifices that
|
Fixes readthedocs/readthedocs.org#9318