Skip to content

Allow to build all formats when building docs from a PR #7116

@njsmith

Description

@njsmith

We recently asked to have pull-request builds enabled for the trio project. This is awesome!

However, we did run into an issue: the PR build passed, but then after we merged, the actual build failed. (And due to unlucky timing, the broken build got tagged and released, so we had to do a .1 release to fix the docs....)

The issue seems to be that when building the docs "for real", RTD builds multiple formats: html, singlehtmllocalmedia, and epub. But when building a PR, it only builds html. And unfortunately, it was the epub build that broke, so we didn't notice until after merging.

Example passing PR build: https://readthedocs.org/projects/trio/builds/11079471/
Example failing build on master: https://readthedocs.org/projects/trio/builds/11086505/

I would expect that the PR build should exactly match the "real" build, because otherwise the green checkmark on the PR build doesn't actually tell you whether the real build will succeed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions