fix(nesting): ignore typealiases in nesting depth by default#6650
Closed
leno23 wants to merge 1 commit into
Closed
fix(nesting): ignore typealiases in nesting depth by default#6650leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Typealiases and associated types are not separate type definitions and should not count toward the type nesting limit unless explicitly configured. Fixes realm#3183
Generated by 🚫 Danger |
Collaborator
|
Closed #3183. We usually don't change defaults after rules/options have been introduced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ignore_typealiases_and_associatedtypestotruein thenestingrule.ignore_typealiases_and_associatedtypes: false.Fixes #3183
Test plan
falseNote
The
ignore_typealiases_and_associatedtypesoption already existed; this change only updates the default to match expected behavior described in the issue.Made with Cursor