Skip to content

Test #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sweetmantech merged 9 commits into from
Jun 18, 2026
Merged

Test #682

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f99277e
feat(measurement-jobs): free-tier card gate (setup mode) + instant ba…
sweetmantech Jun 16, 2026
158a1d4
Merge remote-tracking branch 'origin/main' into test
sweetmantech Jun 16, 2026
5fa5e3a
fix(songstats-backfill): backoff on 429 + defer instead of churn (cha…
sweetmantech Jun 16, 2026
1e9deac
Merge remote-tracking branch 'origin/main' into test
sweetmantech Jun 16, 2026
5f45946
refactor(songstats): remove local quota ledger + budget gate (chat#17…
sweetmantech Jun 16, 2026
5472795
Merge remote-tracking branch 'origin/main' into test
sweetmantech Jun 16, 2026
f24d4c7
feat: POST /api/catalogs (create + materialize from valuation snapsho…
sweetmantech Jun 18, 2026
ace0b01
Merge remote-tracking branch 'origin/main' into test
sweetmantech Jun 18, 2026
a520a1d
fix: LEFT-join artists in catalog-songs read (materialized tracks wer…
sweetmantech Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/supabase/catalog_songs/selectCatalogSongsWithArtists.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ export async function selectCatalogSongsWithArtists(
album,
notes,
updated_at,
song_artists!inner (
song_artists (

@cubic-dev-ai cubic-dev-ai Bot Jun 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0: Removing !inner breaks the artistName filter — with left joins, .eq("songs.song_artists.accounts.name", artistName) only filters which nested accounts rows appear, not which top-level catalog_songs are returned. All songs will be returned regardless of the artistName parameter.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At lib/supabase/catalog_songs/selectCatalogSongsWithArtists.ts, line 58:

<comment>Removing `!inner` breaks the `artistName` filter — with left joins, `.eq("songs.song_artists.accounts.name", artistName)` only filters which nested accounts rows appear, not which top-level catalog_songs are returned. All songs will be returned regardless of the artistName parameter.</comment>

<file context>
@@ -55,9 +55,9 @@ export async function selectCatalogSongsWithArtists(
         notes,
         updated_at,
-        song_artists!inner (
+        song_artists (
           artist,
-          accounts!inner (
</file context>
Suggested change
song_artists (
song_artists!inner (

artist,
accounts!inner (
accounts (
id,
name,
timestamp
Expand Down
Loading