Skip to content

feat(database): add get_credit_spend_digest aggregation RPC #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sweetmantech wants to merge 3 commits into from
Closed

feat(database): add get_credit_spend_digest aggregation RPC #30

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
339167b
feat(database): add get_credit_spend_digest aggregation RPC
arpitgupta1214 Jun 2, 2026
95e125d
fix(database): restrict credit-spend digest RPC to service_role + cla…
arpitgupta1214 Jun 2, 2026
ed8dafc
docs(database): trim verbose header comment on credit-spend digest RPC
arpitgupta1214 Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 84 additions & 0 deletions supabase/migrations/20260602000000_credit_spend_digest.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
-- Top-spenders aggregation for the credit-spend digest cron.
-- Returns a ranked jsonb array (highest spend first) of the top p_limit
-- accounts by total credits over [p_since, now]; '[]' when empty. Each element:
-- { account_id, account_name, account_email, total_cents, turn_count,
-- input_tokens, output_tokens, cached_input_tokens, tool_calls,
-- main_cents, subagent_cents, by_model: {"<model_id>": <cents>} }.
-- account_email = most-recent per account; NULL model_id bucketed as 'unknown'.

CREATE OR REPLACE FUNCTION public.get_credit_spend_digest(
p_since timestamptz,
p_limit integer DEFAULT 10
) RETURNS jsonb
LANGUAGE sql
STABLE
SET search_path = public, pg_temp
AS $$
WITH windowed AS (
SELECT *
FROM public.usage_events
WHERE created_at >= p_since
),
emails AS (
SELECT DISTINCT ON (account_id) account_id, email
FROM public.account_emails
ORDER BY account_id, updated_at DESC
),
Comment on lines +22 to +26

@coderabbitai coderabbitai Bot Jun 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Column updated_at does not exist in account_emails.

The emails CTE references updated_at on line 25, but the account_emails table schema (from migration 20250129000009_account_emails.sql) only includes id, created_at, account_id, and email. This will cause a runtime error when the function executes.

🐛 Proposed fix to use `created_at` instead 
     emails AS (
         SELECT DISTINCT ON (account_id) account_id, email
           FROM public.account_emails
-         ORDER BY account_id, updated_at DESC
+         ORDER BY account_id, created_at DESC
     ),
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
emails AS (
SELECT DISTINCT ON (account_id) account_id, email
FROM public.account_emails
ORDER BY account_id, updated_at DESC
),
emails AS (
SELECT DISTINCT ON (account_id) account_id, email
FROM public.account_emails
ORDER BY account_id, created_at DESC
),
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@supabase/migrations/20260602000000_credit_spend_digest.sql` around lines 22 -
26, The CTE named emails references a nonexistent column updated_at on
account_emails causing runtime failure; change the ORDER BY in the emails CTE to
use the existing created_at column instead so the DISTINCT ON (account_id) picks
the latest row by created_at (update the SELECT in the emails CTE that queries
public.account_emails to order by account_id, created_at DESC).

model_breakdown AS (
SELECT account_id,
jsonb_object_agg(model_id, cents ORDER BY cents DESC) AS by_model
FROM (
SELECT account_id,
coalesce(model_id, 'unknown') AS model_id,
sum(credits_deducted_cents) AS cents
FROM windowed
GROUP BY account_id, coalesce(model_id, 'unknown')
) m
GROUP BY account_id
),
per_account AS (
SELECT account_id,
sum(credits_deducted_cents) AS total_cents,
count(*) AS turn_count,
sum(input_tokens) AS input_tokens,
sum(output_tokens) AS output_tokens,
sum(cached_input_tokens) AS cached_input_tokens,
sum(tool_call_count) AS tool_calls,
coalesce(sum(credits_deducted_cents) FILTER (WHERE agent_type = 'main'), 0) AS main_cents,
coalesce(sum(credits_deducted_cents) FILTER (WHERE agent_type = 'subagent'), 0) AS subagent_cents
FROM windowed
GROUP BY account_id
)
SELECT coalesce(jsonb_agg(obj ORDER BY total_cents DESC), '[]'::jsonb)
FROM (
SELECT pa.total_cents,
jsonb_build_object(
'account_id', pa.account_id,
'account_name', a.name,
'account_email', e.email,
'total_cents', pa.total_cents,
'turn_count', pa.turn_count,
'input_tokens', pa.input_tokens,
'output_tokens', pa.output_tokens,
'cached_input_tokens', pa.cached_input_tokens,
'tool_calls', pa.tool_calls,
'main_cents', pa.main_cents,
'subagent_cents', pa.subagent_cents,
'by_model', coalesce(mb.by_model, '{}'::jsonb)
) AS obj
FROM per_account pa
LEFT JOIN public.accounts a ON a.id = pa.account_id
LEFT JOIN emails e ON e.account_id = pa.account_id
LEFT JOIN model_breakdown mb ON mb.account_id = pa.account_id
ORDER BY pa.total_cents DESC
LIMIT greatest(least(coalesce(p_limit, 10), 1000), 1)
) ranked;
$$;

-- Trusted backend only: the api cron calls this with the service_role key.
-- Cross-account spend + email data must never be reachable by end users, so
-- revoke the implicit PUBLIC grant and do not grant to `authenticated`.
REVOKE EXECUTE ON FUNCTION public.get_credit_spend_digest(timestamptz, integer) FROM PUBLIC;

GRANT EXECUTE ON FUNCTION public.get_credit_spend_digest(timestamptz, integer)
TO service_role;