Skip to content

[QA] Add StructArmed to QA#482

Merged
TomasVotruba merged 2 commits into
mainfrom
add-structarmed-to-qa
May 26, 2026
Merged

[QA] Add StructArmed to QA#482
TomasVotruba merged 2 commits into
mainfrom
add-structarmed-to-qa

Conversation

@samsonasik

@samsonasik samsonasik commented May 26, 2026

Copy link
Copy Markdown
Member

Similar to PR on rector-src:

This PR also adds StructArmed to github workflow static analysis for QA.

This PR uses the PSR1 + PSR4 preset, and already found violation of double underscored __ in class constant that fixed in this PR.

@samsonasik

samsonasik commented May 26, 2026

Copy link
Copy Markdown
Member Author

For note, rector-src needs update if this going to be merged

https://github.com/rectorphp/rector-src/blob/b095655ec65eb4ff29c9dd4ce06aff6d5b9f4bff/src/Configuration/RectorConfigBuilder.php#L525

that uses the double underscore __ constant.

@samsonasik samsonasik requested a review from TomasVotruba May 26, 2026 18:26
@samsonasik

Copy link
Copy Markdown
Member Author

@TomasVotruba ready 👍

@TomasVotruba

Copy link
Copy Markdown
Member

LGTM 👍

@TomasVotruba TomasVotruba merged commit 18872bf into main May 26, 2026
8 checks passed
@TomasVotruba TomasVotruba deleted the add-structarmed-to-qa branch May 26, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants