Allow removing credentials from job templates if they are not set or set to empty when job_template_enforce_defaults is true#84
Merged
djdanielsson merged 2 commits intoredhat-cop:develfrom Feb 2, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In AAP, if a job templates have credentials there is no way to remove it using configuration as code.
This PR makes it possible to do so if job_template_enforce_defaults is set to true, and if the user do not set the credential or set an empty credential in the JT yaml definition.
It is worth noting that this change might result unwanted behavior if configuration as code is not reflecting real world AAP configuration:
Example :
if
then the credential will be removed from the JT.
How should this be tested?
Is there a relevant Issue open for this?
N/A
Other Relevant info, PRs, etc
N/A