Prefix variables from defaults/main.yml with leapp_ for consistency#317
Merged
spetrosi merged 1 commit intoredhat-cop:mainfrom Dec 18, 2025
Merged
Prefix variables from defaults/main.yml with leapp_ for consistency#317spetrosi merged 1 commit intoredhat-cop:mainfrom
leapp_ for consistency#317spetrosi merged 1 commit intoredhat-cop:mainfrom
Conversation
richm
reviewed
Dec 17, 2025
richm
reviewed
Dec 17, 2025
richm
reviewed
Dec 17, 2025
richm
reviewed
Dec 17, 2025
richm
reviewed
Dec 17, 2025
spetrosi
force-pushed
the
prefix-simpler
branch
from
2b5466a to
3db556f
Compare
spetrosi
force-pushed
the
prefix-simpler
branch
from
d4c3b61 to
2275573
Compare
Collaborator
|
Except for the |
spetrosi
force-pushed
the
prefix-simpler
branch
3 times, most recently
from
fd22240 to
b9f5e33
Compare
Collaborator
Author
|
[citest] |
richm
reviewed
Dec 17, 2025
spetrosi
force-pushed
the
prefix-simpler
branch
from
b9f5e33 to
135d962
Compare
Collaborator
Author
|
[citest] |
richm
approved these changes
Dec 17, 2025
Collaborator
|
I'm working on debugging the el7 test failure - go ahead and merge this PR |
1. Prefix variables that are not prefixed already. 2. Edit variables that had leapp in names but not as prefix to use leapp_ as prefix. 3. Assign old variables to new varnames if an old name is set for backward compatibility. 4. Save variables with normal values (without the default filter for backward compatilibility) in a comment so that we can easily remove compatibility in future when needed. Say, in couple years when we are sure that no users have old deprecated variables set.
spetrosi
force-pushed
the
prefix-simpler
branch
from
135d962 to
92b1cde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.