fix: Vendor infra.leapp.modprobe inside the collection#343
Merged
spetrosi merged 1 commit intoredhat-cop:mainfrom Jan 21, 2026
Merged
fix: Vendor infra.leapp.modprobe inside the collection#343spetrosi merged 1 commit intoredhat-cop:mainfrom
spetrosi merged 1 commit intoredhat-cop:mainfrom
Conversation
spetrosi
force-pushed
the
vendor-modprobe
branch
2 times, most recently
from
fac6395 to
1da2789
Compare
Collaborator
Author
|
[citest] |
richm
approved these changes
Jan 20, 2026
Collaborator
Author
Collaborator
Author
|
|
spetrosi
force-pushed
the
vendor-modprobe
branch
from
1da2789 to
51a7ce3
Compare
This is required to remove dependency on community.general collection
spetrosi
force-pushed
the
vendor-modprobe
branch
from
51a7ce3 to
3dc9d21
Compare
spetrosi
commented
Jan 21, 2026
| - community.general.redhat_subscription | ||
| - community.general.modprobe | ||
| - community.general.archive | ||
| - community.general.rhsm_repository |
Collaborator
Author
There was a problem hiding this comment.
Removing couple more entries that were replaced in previous PRs.
Collaborator
Author
|
[citest] |
richm
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to remove dependency on community.general collection.
I've done this by downloading community-general-11.4.2 from https://galaxy.ansible.com/download/community-general-11.4.2.tar.gz and copying
plugins/modules/modprobe.pyfrom it to this collection.I took version 11.4.2 because this is what rhel-system-roles uses, this version is verified to work with all Python versions that we need to support.
community.general now has a tendency to add features that are not supported on older Python which RHEL 7 uses, so we cannot use latest version.
In the module I've added a warning
- "WARNING: Do not use this plugin directly! It is only for role internal use."and replacedcommunity.general.withinfra.leapp..Then had to copy plugins/doc_fragments/attributes.py because it is needed to build module documentation.