Skip to content

fix satellite subscription handling#349

Merged
PeterMocary merged 2 commits intoredhat-cop:mainfrom
PeterMocary:fix-satellite-registration
Feb 12, 2026
Merged

fix satellite subscription handling#349
PeterMocary merged 2 commits intoredhat-cop:mainfrom
PeterMocary:fix-satellite-registration

Conversation

@PeterMocary
Copy link
Collaborator

@PeterMocary PeterMocary commented Feb 5, 2026

As a followup on PR #348, fix the satellite subscription problem which originates from use of handlers and include_role incompatibility. Since using include_role is not supported in handlers (ansible/ansible#20493), it is not a good idea to wrap it in include_tasks and use it anyways. Thus, this patch removes the handlers entirely and converts them into regular tasks. This solution is inline with the original idea (#348 (comment)) and basically similar to the key handling in the upgrade role.

Not tested yet, although I'm already able to setup satellite host and upgrade it. I'll try it soon.

@richm
Copy link
Collaborator

richm commented Feb 5, 2026

[citest]

@PeterMocary PeterMocary force-pushed the fix-satellite-registration branch from 86b8dc1 to fdbaeb3 Compare February 5, 2026 08:55
@PeterMocary
Copy link
Collaborator Author

Changed the when statements so that they handle null in variables. Defined these to empty string, however, that could be changed back to null if not desired. In my opinion having empty string as default is better.

@PeterMocary
Copy link
Collaborator Author

[citest]

@PeterMocary PeterMocary force-pushed the fix-satellite-registration branch 2 times, most recently from 181c8ab to 60820ba Compare February 9, 2026 17:29
@PeterMocary PeterMocary force-pushed the fix-satellite-registration branch from 60820ba to 121d482 Compare February 10, 2026 10:43
@PeterMocary
Copy link
Collaborator Author

[citest]

@PeterMocary PeterMocary force-pushed the fix-satellite-registration branch from 121d482 to 07568b8 Compare February 10, 2026 17:03
@PeterMocary
Copy link
Collaborator Author

[citest]

@PeterMocary PeterMocary force-pushed the fix-satellite-registration branch from 07568b8 to 20063ea Compare February 10, 2026 17:19
@PeterMocary
Copy link
Collaborator Author

[citest]

@PeterMocary
Copy link
Collaborator Author

I tried upgrading 8to9 with multiple different activation keys (pre_leapp, post_leapp and regular leapp AK) with different repositories exposed. It worked fine and reregistered every time resulting in a system subscribed with post_leapp key.

@PeterMocary PeterMocary marked this pull request as ready for review February 11, 2026 12:36
@richm
Copy link
Collaborator

richm commented Feb 11, 2026

Ready to merge?

@PeterMocary
Copy link
Collaborator Author

[citest]

@PeterMocary
Copy link
Collaborator Author

PeterMocary commented Feb 12, 2026

I've made the pre and post activation keys mirror the upgrade key if not specified. This makes them optional.

Tested on 8to9 satellite upgrade with multiple keys and single key. Both worked fine.

Variables for pre-upgrade and post-upgrade Satellite activation keys
now default to the upgrade activation key, making them optional but
recommended.
@PeterMocary PeterMocary force-pushed the fix-satellite-registration branch from b64cf75 to c94d304 Compare February 12, 2026 08:34
@PeterMocary
Copy link
Collaborator Author

Fixed duplicated readme section and added changelog note about the activation key variables change.

@PeterMocary
Copy link
Collaborator Author

[citest]

@PeterMocary PeterMocary merged commit a18fed3 into redhat-cop:main Feb 12, 2026
26 checks passed
@PeterMocary PeterMocary deleted the fix-satellite-registration branch February 12, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants