Skip to content

Conversation

@vrubezhny
Copy link
Collaborator

@vrubezhny vrubezhny commented Jul 24, 2025

A Progress Indicator is added in order to not block UI at connection and to track the Connection process

Screencast.From.2025-07-23.19-52-42.mp4

Fixes eclipse-che/che#23471

A Progress Indicator is added in order to not block UI at connection and to track the Connection process

Fixes eclipse-che/che#23471

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny vrubezhny requested a review from azatsarynnyy as a code owner July 24, 2025 15:04
@vrubezhny vrubezhny requested review from adietish and azatsarynnyy and removed request for azatsarynnyy July 24, 2025 15:05
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 132 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (71098f6) to head (c3cbcfa).
Report is 180 commits behind head on main.

Files with missing lines Patch % Lines
...at/devtools/gateway/DevSpacesConnectionProvider.kt 0.00% 132 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main    #145    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files          4      25    +21     
  Lines         26     867   +841     
  Branches       0     112   +112     
======================================
- Misses        26     867   +841     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* turned StartupProgressIndicator to private inner class
* extracted thinClient callbacks to separate methods
Copy link
Collaborator

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome improvement: UI is not frozen any more, progress is now reported. Works very well for me. LGTM

@adietish adietish merged commit 543be1d into redhat-developer:main Jul 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jetbrains Gateway is freezing UI while connecting

3 participants