odo link should store link information in devfile

[kadel]

/kind user-story

User Story

As a developer working with odo, I want to be able to easily share link connections to a service or to another odo component, with my team so they can start application with the service in the same way as me.

Acceptance Criteria

• odo link should store link description in devfile. For example, if ServiceBindingOperator is used ServiceBinding CR will be stored in devfile as kubernetes component (odo link and odo unlink write to devfile without deploying to cluster #4819).
• odo unlink should remove appropriate kubernetes component from devfile (deletion from the cluster will happen during odo push) (odo link and odo unlink write to devfile without deploying to cluster #4819)
• odo link should work when linking to an Operator backed service that’s not pushed yet. But it shouldn’t work when trying to link to another component that’s not pushed yet.
• odo describe should list all links for the current component together with the status. The status will be similar to URL statuses as the link can be present locally but missing on the cluster, or present on the cluster and missing locally, or present in both places. (Add linked component/service information in odo describe for devfile component and operator services #3734). Also the JSON output (odo describe -o json) for this.

Links

• Feature Request:
• Related issue:

/kind user-story

[kadel]

/area link

[openshift-ci-robot]

@kadel: The label(s) area/link cannot be applied, because the repository doesn't have them

Details

In response to this:

/area link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dharmit]

• odo unlink should remove appropriate kubernetes component from devfile (deletion from the cluster will happen during odo push)

What I can't wrap my head around is that how will odo know that some resource on the cluster (here a ServiceBinding) needs to be deleted. Here's the flow we're looking for:

1. odo link will store the manifest of a ServiceBinding in devfile.yaml
2. odo push will create the ServiceBinding on the cluster if one doesn't exist already.
3. odo unlink will remove the manifest of the ServiceBinding from devfile.yaml
4. odo push should delete the ServiceBinding from the devfile.yaml

Now, between step 3 & 4, how is odo going to know that it has to delete something from the cluster? Should we store some information about the link created in step 1 in the .odo/env/env.yaml file?

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[dharmit]

/remove-lifecycle stale