Test `odo link` extensively for 2.3 release

[dharmit]

Goal

odo link has added a bunch of capabilities and fixed some issues. This issue tracks all the scenarios we should check before 2.3 release and make sure they are working well.

Acceptance Criteria

A component means devfile based component

Must haves

• odo link a component with an Operator backed service (Test odo link extensively for 2.3 release #4801 (comment))
• odo link a component with another component (Test odo link extensively for 2.3 release #4801 (comment))
• odo link --name a component with an Operator backed service and check if SBR (kubectl get sbr) gets created with the provided name (Test odo link extensively for 2.3 release #4801 (comment))
• odo link --name a component with another odo component and check if SBR (kubectl get sbr) gets created with the provided name (Test odo link extensively for 2.3 release #4801 (comment))
• odo link --name --bindAsFiles and see if values are injected as files instead of environment variables (Test odo link extensively for 2.3 release #4801 (comment))
• odo link a component with more than one Operator backed service or component (Test odo link extensively for 2.3 release #4801 (comment))
• odo link --app

Stretch

• Link component A with component B; link component B with an Operator backed service. Ideally, do this with an end-to-end microservices application. (Test odo link extensively for 2.3 release #4801 (comment))
• odo describe should list all the services linked to the component. See odo link and odo unlink write to devfile without deploying to cluster #4819 (comment)
• Delete a linked service/component and check what happens. (Test odo link extensively for 2.3 release #4801 (comment))

[valaparthvi]

Tested this issue against @feloy's PR #4819 #4866 and operators such as postgresql, and etcd on Openshift 4.7, and minikube.
All the ticked acceptance criteria work well. This testing involves linking, checking the variable was rightfully exposed or binding file was created, un-linking and describing.

[valaparthvi]

Testing AC - Deleting a linked service/component

Steps to reproduce -

1. Create a component and push it.
2. Create another component or a service and push it.
3. Create a link to the other component/service and push it.
4. Delete the component/service created in step 2.
5. Try un-linking the deleted component/service from step 4.

Got -

 ✗  couldn't find service named XXX. Refer "odo service list" to see list of running services

 ✗  couldn't find component named XXX. Refer "odo list" to see list of running components

Want -
Not sure what could be the expected outcome here. It doesn't necessarily block anything because the user can still delete the linked service via web console.

[feloy]

Testing AC - Deleting a linked service/component

Steps to reproduce -

1. Create a component and push it.
2. Create another component or a service and push it.
3. Create a link to the other component/service and push it.
4. Delete the component/service created in step 2.
5. Try un-linking the deleted component/service from step 4.

Got -

 ✗  couldn't find service named XXX. Refer "odo service list" to see list of running services

 ✗  couldn't find component named XXX. Refer "odo list" to see list of running components

Want -
Not sure what could be the expected outcome here. It doesn't necessarily block anything because the user can still delete the linked service via web console.

Good catch.

Should odo forbid to delete a service/component when a link references it, or should odo delete the link when deleting the service/component?

[dharmit]

Should odo forbid to delete a service/component when a link references it, or should odo delete the link when deleting the service/component?

IMO, odo should forbid deletion of a service/component that's linked to another component. But that should not be the case if the component initiated the link (step 1 in #4801 (comment)). For such components, odo should delete the binding (which it already does, thanks for ownerReferences.)

@valaparthvi can you open a bug to track this?

[valaparthvi]

@valaparthvi can you open a bug to track this?

#4871

[valaparthvi]

@dharmit IMO with @feloy's #4866 PR, odo link works well and is ready for a release. I cannot think of any more scenarios to test.
Is it alright if I mark this issue as Done for this sprint? Or should we wait for 4866 to be in?

[dharmit]

@valaparthvi I'm good by marking it Done.

[dharmit]

/close

[openshift-ci]

@dharmit: Closing this issue.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.