Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

Custom link names and bindAsFiles option for SB#4729

Merged
openshift-merge-robot merged 10 commits into
redhat-developer:mainfrom
feloy:feature-4693/link-names
Jun 3, 2021
Merged

Custom link names and bindAsFiles option for SB#4729
openshift-merge-robot merged 10 commits into
redhat-developer:mainfrom
feloy:feature-4693/link-names

Conversation

@feloy
Copy link
Copy Markdown
Contributor

@feloy feloy commented May 18, 2021 •
edited
Loading

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #4693

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

  • Update changelog

  • I have read the test guidelines

TODO

How to test changes / Special notes to the reviewer:

On a cluster with some Operator backed services installed (for example etcdoperator.v0.9.4-clusterwide):

$ odo create nodejs 
$ odo service create etcdoperator.v0.9.4-clusterwide/EtcdCluster myetcd
$ odo push
$ odo link EtcdCluster/myetcd --name myetcd-config
$ oc get servicebinding myetcd-config
# myetcd-config should exist

$ odo unlink EtcdCluster/myetcd
$ odo link EtcdCluster/myetcd --name myetcd-config --bind-as-files
$ oc get servicebinding myetcd-config -o jsonpath='{.spec.bindAsFiles}'
# should output "true"

# cleanup
$ odo unlink EtcdCluster/myetcd
$ odo service delete EtcdCluster/myetcd

@openshift-ci openshift-ci Bot requested review from dharmit and mik-dass May 18, 2021 13:48
@feloy feloy changed the title Custom link names and bindAsFiles option for SB WIP: Custom link names and bindAsFiles option for SB May 18, 2021
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 18, 2021
@feloy feloy changed the title WIP: Custom link names and bindAsFiles option for SB Custom link names and bindAsFiles option for SB May 19, 2021
@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. labels May 19, 2021
@feloy feloy force-pushed the feature-4693/link-names branch from 55a23f7 to b3f1d32 Compare May 19, 2021 11:59
@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. labels May 19, 2021
@feloy feloy force-pushed the feature-4693/link-names branch from b3f1d32 to 95ca61f Compare May 20, 2021 09:46
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 20, 2021
@feloy
Copy link
Copy Markdown
Contributor Author

feloy commented May 20, 2021

/retest

@feloy feloy force-pushed the feature-4693/link-names branch from 95ca61f to 520ed67 Compare May 20, 2021 13:47
@feloy
Copy link
Copy Markdown
Contributor Author

feloy commented May 21, 2021

/retest

2 similar comments
@feloy
Copy link
Copy Markdown
Contributor Author

feloy commented May 21, 2021

/retest

@feloy
Copy link
Copy Markdown
Contributor Author

feloy commented May 21, 2021

/retest

@feloy
Copy link
Copy Markdown
Contributor Author

feloy commented May 25, 2021

/test psi-kubernetes-integration-e2e

@feloy feloy force-pushed the feature-4693/link-names branch from 520ed67 to d2863d2 Compare May 25, 2021 15:09
@feloy
Copy link
Copy Markdown
Contributor Author

feloy commented May 26, 2021

/test psi-kubernetes-integration-e2e

@feloy feloy force-pushed the feature-4693/link-names branch from 9c06c76 to 4981d4d Compare May 31, 2021 13:27
mik-dass
mik-dass reviewed Jun 2, 2021
View reviewed changes
Comment thread pkg/envinfo/envinfo_test.go

func TestSearchLinkName(t *testing.T) {
tests := []struct {
ei *EnvInfo
Copy link
Copy Markdown
Contributor

@mik-dass mik-dass Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case name describing the test scenario.

mik-dass
mik-dass reviewed Jun 2, 2021
View reviewed changes
Comment thread tests/integration/cmd_link_unlink_test.go Outdated
})
})

Context("When running an etcd operator backed service", func() {
Copy link
Copy Markdown
Contributor

@mik-dass mik-dass Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these tests should be in https://github.com/openshift/odo/blob/main/tests/integration/operatorhub/cmd_service_test.go file. A similar linking scenario is already present in that file.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jun 2, 2021
@mik-dass
Copy link
Copy Markdown
Contributor

mik-dass commented Jun 2, 2021

How to test changes / Special notes to the reviewer:

Please add the steps to test the PR.

@kadel
Copy link
Copy Markdown
Member

kadel commented Jun 2, 2021 •
edited
Loading

Finaly managed to test this.
Code also looks good to me. I'm not adding /lgtm. Leaving this for @mik-dass
/assign @mik-dass

@kadel kadel closed this Jun 2, 2021
@kadel kadel reopened this Jun 2, 2021
@feloy
Copy link
Copy Markdown
Contributor Author

feloy commented Jun 2, 2021

/retest

mik-dass
mik-dass approved these changes Jun 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit 6d55158 into redhat-developer:main Jun 3, 2021
@feloy feloy deleted the feature-4693/link-names branch June 3, 2021 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dharmit dharmit Awaiting requested review from dharmit

1 more reviewer

@mik-dass mik-dass mik-dass approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mik-dass mik-dass

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Custom link names and bindAsFiles option for SB

4 participants

@feloy @mik-dass @kadel @openshift-merge-robot