Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

[WIP] Add linked service information in odo describe#4856

Closed
feloy wants to merge 19 commits into
redhat-developer:mainfrom
feloy:feature-3734/odo-describe-links
Closed

[WIP] Add linked service information in odo describe#4856
feloy wants to merge 19 commits into
redhat-developer:mainfrom
feloy:feature-3734/odo-describe-links

Conversation

@feloy
Copy link
Copy Markdown
Contributor

@feloy feloy commented Jun 29, 2021

/kind feature

(Branched from #4819)

What does this PR do / why we need it:

  • Shows the linked components with variables / files when pushed
  • Shows the linked components names when not pushed
  • Shows the linked services with variables / files when pushed
  • Shows the linked services names when not pushed

Which issue(s) this PR fixes:

Fixes #3734

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

  • Update changelog

  • I have read the test guidelines

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci Bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jun 29, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 29, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from feloy after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from mik-dass and prietyc123 June 29, 2021 06:37
@feloy feloy changed the title Add linked service information in odo describe [WIP] Add linked service information in odo describe Jun 29, 2021
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 29, 2021
@feloy feloy force-pushed the feature-3734/odo-describe-links branch from 61a3818 to bd23376 Compare June 30, 2021 07:24
@feloy feloy force-pushed the feature-3734/odo-describe-links branch from bd23376 to a8bd11d Compare July 1, 2021 12:42
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 1, 2021

@feloy: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jul 1, 2021
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 1, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
5.3% 5.3% Duplication

@feloy feloy closed this Jul 1, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 1, 2021

@feloy: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/psi-unit-test-mac bd23376 link /test psi-unit-test-mac
ci/prow/psi-unit-test-windows bd23376 link /test psi-unit-test-windows
ci/prow/psi-kubernetes-integration-e2e bd23376 link /test psi-kubernetes-integration-e2e
ci/prow/v4.7-integration-e2e a8bd11d link /test v4.7-integration-e2e
ci/prow/unit a8bd11d link /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add linked component/service information in odo describe for devfile component and operator services

1 participant