Skip to content

ci: Fix the pre-commit checks - #124

Merged
rm3l merged 1 commit into
redhat-developer:mainfrom
rm3l:ci_fix_pre-commit-checks
Apr 3, 2025
Merged

ci: Fix the pre-commit checks#124
rm3l merged 1 commit into
redhat-developer:mainfrom
rm3l:ci_fix_pre-commit-checks

Conversation

@rm3l

@rm3l rm3l commented Apr 3, 2025

Copy link
Copy Markdown
Member

Description of the change

This PR makes sure to run the pre-commit checks on all files.
For some reason, they used to skip the files to check.

Ideally, the workflow could auto-push the changes after the pre-commit run, but that could come up later.

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

For some reason, they used to skip the files to check
@openshift-ci
openshift-ci Bot requested review from gazarenkov and tumido April 3, 2025 10:21
@sonarqubecloud

sonarqubecloud Bot commented Apr 3, 2025

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant