chore: merge downstream chart content to rhdh-chart - #130

Merged

openshift-merge-bot[bot] merged 1 commit into

redhat-developer:mainfrom

Omar-AlJaljuli:merge_chart_to_downstream

May 7, 2025

Omar-AlJaljuli commented Apr 14, 2025

Description of the change

Existing or Associated Issue(s)

Additional Information

closes RHIDP-1477

Checklist

Chart version bumped in Chart.yaml according to semver.
Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
JSON Schema template updated and re-generated the raw schema via pre-commit hook.
List tests pass for Chart using the Chart Testing tool and the ct lint command.

Omar-AlJaljuli requested a review from a team as a code owner

April 14, 2025 17:40

openshift-ci Bot requested review from gazarenkov and rm3l

April 14, 2025 17:40

coreydaley reviewed

View reviewed changes

.rhdh/scripts/installation.sh Outdated

coreydaley reviewed

View reviewed changes

.rhdh/scripts/installation.sh Outdated

coreydaley reviewed

View reviewed changes

.rhdh/scripts/installation.sh Outdated

coreydaley reviewed

View reviewed changes

.rhdh/scripts/install.sh Outdated

coreydaley reviewed

View reviewed changes

.rhdh/scripts/install.sh

rm3l reviewed

View reviewed changes

.rhdh/docs/installing-ci-charts.adoc Outdated

.rhdh/scripts/install.sh Outdated

.rhdh/scripts/install.sh

.rhdh/scripts/install.sh

charts/backstage/Chart.yaml Outdated

charts/backstage/Chart.yaml

charts/backstage/Chart.yaml

charts/backstage/Chart.yaml Outdated

charts/backstage/Chart.yaml

charts/backstage/values.yaml Outdated

Omar-AlJaljuli force-pushed the merge_chart_to_downstream branch 2 times, most recently from 9272df9 to c271cf4 Compare

April 22, 2025 19:41

rm3l requested changes

View reviewed changes

rm3l left a comment •

edited

Loading

Member

@Omar-AlJaljuli A chart version bump is needed again to fix the CI. Could you also rebase your PR and fix the conflicts reported? Thanks.

Omar-AlJaljuli force-pushed the merge_chart_to_downstream branch from c271cf4 to 881a67e Compare

April 24, 2025 18:08

rm3l requested changes

View reviewed changes

charts/backstage/Chart.yaml

Omar-AlJaljuli force-pushed the merge_chart_to_downstream branch from 881a67e to 1364ee6 Compare

April 28, 2025 16:24

Omar-AlJaljuli marked this pull request as draft

April 28, 2025 19:42

openshift-ci Bot added the do-not-merge/work-in-progress label

Omar-AlJaljuli commented Apr 28, 2025 •

edited

Loading

Author

I need to check if the current prepare.sh will still work if these changes are merged, or if this is blocked by that task. My guess is that it should still work fine.

Omar-AlJaljuli marked this pull request as ready for review

April 30, 2025 18:50

openshift-ci Bot removed the do-not-merge/work-in-progress label

openshift-ci Bot requested review from coreydaley and rm3l

April 30, 2025 18:50

Omar-AlJaljuli commented May 1, 2025

Author

I need to check if the current prepare.sh will still work if these changes are merged, or if this is blocked by that task. My guess is that it should still work fine.

I checked it, its all good.

rm3l reviewed

View reviewed changes

charts/backstage/Chart.yaml Outdated

rm3l reviewed

View reviewed changes

rm3l left a comment

Member

@Omar-AlJaljuli Could you run the pre-commit hooks and push the changes? Thanks.
https://github.com/redhat-developer/rhdh-chart/actions/runs/14715680021/job/41298383128?pr=130

Omar-AlJaljuli force-pushed the merge_chart_to_downstream branch from b5dde5e to 198af52 Compare

May 5, 2025 21:14


          chore: merge downstream chart content into rhdh-chart and include ins…

00ddeda

…tall script+docs

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

bump version

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Omar-AlJaljuli force-pushed the merge_chart_to_downstream branch from f4b6ba7 to 00ddeda Compare

May 7, 2025 02:51

sonarqubecloud Bot commented May 7, 2025

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

rm3l approved these changes

View reviewed changes

rm3l left a comment

Member

/lgtm

openshift-ci Bot assigned rm3l

openshift-ci Bot added the lgtm label

openshift-merge-bot Bot merged commit 6c418ed into redhat-developer:main

Omar-AlJaljuli mentioned this pull request

chore: update default chart settings using downstream patches so we can remove Chart_patch.yaml (RHIDP-7529) #162

Merged

5 tasks

nickboldt mentioned this pull request

chore: update default chart settings using downstream patches so we can remove Chart_patch.yaml (RHIDP-7529) #163

Merged

5 tasks

rm3l mentioned this pull request

rhidp 9361 pin the rhdh image to specific 1.y tag when creating a release 1.y branch in the rhdh operator and rhdh chart repos 1.6 #253

Closed

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm