Skip to content

fix: documentation bug for backstage chart readme, in orchestrator - #144

Merged
openshift-merge-bot[bot] merged 7 commits into
redhat-developer:mainfrom
elai-shalev:fix/7255
May 12, 2025
Merged

fix: documentation bug for backstage chart readme, in orchestrator#144
openshift-merge-bot[bot] merged 7 commits into
redhat-developer:mainfrom
elai-shalev:fix/7255

Conversation

@elai-shalev

@elai-shalev elai-shalev commented May 6, 2025

Copy link
Copy Markdown

This PR will close the outstanding issues addressed in this doc bug.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@elai-shalev
elai-shalev requested a review from a team as a code owner May 6, 2025 07:00
@openshift-ci
openshift-ci Bot requested review from gazarenkov and tumido May 6, 2025 07:01
Comment thread charts/backstage/README.md Outdated
@elai-shalev

Copy link
Copy Markdown
Author

@rm3l ptal when you have a minute, just some doc changes

@rm3l rm3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

Comment thread charts/backstage/README.md.gotmpl Outdated
Comment thread charts/backstage/README.md.gotmpl Outdated
Comment thread charts/backstage/README.md.gotmpl Outdated
Comment thread charts/backstage/README.md.gotmpl Outdated
Comment thread charts/backstage/README.md.gotmpl Outdated
Comment thread charts/backstage/README.md.gotmpl Outdated
Comment thread charts/backstage/README.md.gotmpl Outdated
Comment thread charts/backstage/README.md.gotmpl Outdated
Comment thread charts/backstage/README.md.gotmpl Outdated
Comment thread charts/backstage/README.md.gotmpl Outdated
Comment thread charts/backstage/README.md.gotmpl Outdated
@elai-shalev

elai-shalev commented May 8, 2025

Copy link
Copy Markdown
Author

Thanks @rm3l, I've updated the PR to address all of your comments.

Comment thread charts/backstage/README.md.gotmpl Outdated

@rm3l rm3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few style changes.

Comment thread charts/backstage/README.md Outdated
Comment thread charts/backstage/README.md.gotmpl Outdated
Comment thread charts/backstage/README.md.gotmpl Outdated
Co-authored-by: rm3l <rm3l@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

⚠️ Files changed after running the pre-commit hooks

Those changes should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

@rm3l rm3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label May 12, 2025
@rm3l rm3l closed this May 12, 2025
@rm3l rm3l reopened this May 12, 2025
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants