Skip to content

chore: include doc+script for installing RHDH 1.6 (RHIDP-1477, RHIDP-6668, RHIDP-7251) - partial pick from main [release-1.6] - #158

Merged
nickboldt merged 1 commit into
release-1.6from
6668-7251_16
May 14, 2025
Merged

chore: include doc+script for installing RHDH 1.6 (RHIDP-1477, RHIDP-6668, RHIDP-7251) - partial pick from main [release-1.6]#158
nickboldt merged 1 commit into
release-1.6from
6668-7251_16

Conversation

@nickboldt

Copy link
Copy Markdown
Member

What does this PR do?

chore: include doc+script for installing RHDH 1.6 (RHIDP-1477, RHIDP-6668, RHIDP-7251) - partial pick from main [release-1.6]

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…6668, RHIDP-7251) - partial pick from main [release-1.6]

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@openshift-ci
openshift-ci Bot requested review from coreydaley and davidfestal May 12, 2025 19:42
@sonarqubecloud

Copy link
Copy Markdown

@nickboldt

Copy link
Copy Markdown
Member Author

Manual c'pick of #152 for 1.6 branch

cc: @Omar-AlJaljuli @rm3l

@nickboldt
nickboldt enabled auto-merge (squash) May 12, 2025 19:43
@nickboldt
nickboldt requested review from Omar-AlJaljuli and rm3l May 12, 2025 19:43
@nickboldt nickboldt changed the title chore: include doc+script for installing... chore: include doc+script for installing RHDH 1.6 (RHIDP-1477, RHIDP-6668, RHIDP-7251) - partial pick from main [release-1.6] May 12, 2025
@Omar-AlJaljuli

Copy link
Copy Markdown

@nickboldt I agree we should cherrypick to 1.6 and 1.5. But wouldn't it be good to cherry-pick everything related to the migration from rhdh-bot to this repo?

@rm3l

rm3l commented May 13, 2025

Copy link
Copy Markdown
Member

I agree we should cherrypick to 1.6 and 1.5. But wouldn't it be good to cherry-pick everything related to the migration from rhdh-bot to this repo?

I think it is fine to just backport the doc and script changes since they are just about installing the CI chart from quay.io. The other changes to the chart itself might be a bit risky to add to z releases, IMO. WDYT?

@rm3l rm3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I guess we should wait until 1.6.0 is out.

/lgtm
/hold

@rm3l

rm3l commented May 13, 2025

Copy link
Copy Markdown
Member

/override "Lint Metadata"
/override "Test Latest Release"

Changes not related. And this job will actually never be triggered based on the paths here: https://github.com/redhat-developer/rhdh-chart/blob/release-1.6/.github/workflows/test.yml#L10-L15

@openshift-ci

openshift-ci Bot commented May 13, 2025

Copy link
Copy Markdown

@rm3l: Overrode contexts on behalf of rm3l: Lint Metadata, Test Latest Release

Details

In response to this:

/override "Lint Metadata"
/override "Test Latest Release"

Changes not related. And this job will actually never be triggered based on the paths here: https://github.com/redhat-developer/rhdh-chart/blob/release-1.6/.github/workflows/test.yml#L10-L15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rm3l
rm3l disabled auto-merge May 13, 2025 12:37
@nickboldt

Copy link
Copy Markdown
Member Author

/cherry-pick release-1.5

@openshift-cherrypick-robot

Copy link
Copy Markdown

@nickboldt: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nickboldt
nickboldt merged commit 45478bf into release-1.6 May 14, 2025
@nickboldt
nickboldt deleted the 6668-7251_16 branch May 14, 2025 18:10
@openshift-cherrypick-robot

Copy link
Copy Markdown

@nickboldt: new pull request created: #159

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants